From: Simon Horman <horms@verge.net.au>
To: Valentine <valentine.barshak@cogentembedded.com>
Cc: linux-sh@vger.kernel.org, linux-ide@vger.kernel.org,
devicetree@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Kumar Gala <galak@codeaurora.org>, Tejun Heo <tj@kernel.org>,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH V4] sata_rcar: Add R-Car Gen2 SATA PHY support
Date: Fri, 1 Nov 2013 09:13:40 +0900 [thread overview]
Message-ID: <20131101001340.GB6818@verge.net.au> (raw)
In-Reply-To: <5272326B.3050500@cogentembedded.com>
On Thu, Oct 31, 2013 at 02:35:23PM +0400, Valentine wrote:
> On 10/31/2013 10:01 AM, Simon Horman wrote:
> >On Wed, Oct 30, 2013 at 09:14:21PM +0400, Valentine Barshak wrote:
> >>R-Car Gen2 SoCs have a different PHY which is not compatible
> >>with the older R-Car H1 (R8A7779) version.
> >>This adds OF/platform device id tables and PHY initialization
> >>callbacks for the following Gen2 SoCs:
> >> * R-Car H2: R8A7790;
> >> * R-Car M2: R8A7791.
> >>
> >>PHY initialization method is chosen based on the device id.
> >>Default PHY settings are applied for Gen2 SoCs, which should
> >>suit the Gen2 boards available.
> >>
> >>While at it, this also adds "sata-r8a7779" compatibility string
> >>for R-Car H1 SATA, while keeping the old one for compatibility.
> >>
> >>Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
> >
> >I know we are going around and around in circles regarding the bindings.
> >But I think you need to submit that patch which documents the bindings
> >that exist after this patch in order for the bindings, as they are
> >used here, to be reviewed by the device tree people.
>
> OK, I'll resend.
>
> >
> >Also, I think I found a typo which I have noted below.
>
> There's no typo. I'm using "sata_rcar" device name for compatibility with the current r8a7779 code
> that uses the driver and registers "sata_rcar" device.
Thanks, sorry for the noise.
prev parent reply other threads:[~2013-11-01 0:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 17:14 [PATCH V4] sata_rcar: Add R-Car Gen2 SATA PHY support Valentine Barshak
2013-10-31 6:01 ` Simon Horman
2013-10-31 10:35 ` Valentine
2013-11-01 0:13 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131101001340.GB6818@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
--cc=valentine.barshak@cogentembedded.com \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).