From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sascha Hauer Subject: Re: [PATCHv9][ 4/6] pinctrl: pinctrl-imx: add imx25 pinctrl driver Date: Mon, 4 Nov 2013 14:13:49 +0100 Message-ID: <20131104131349.GH17135@pengutronix.de> References: <1383210928-18906-1-git-send-email-denis@eukrea.com> <1383210928-18906-4-git-send-email-denis@eukrea.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1383210928-18906-4-git-send-email-denis@eukrea.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Denis Carikli Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Eric =?iso-8859-15?Q?B=E9nard?= , Pawel Moll , Stephen Warren , Linus Walleij , Ian Campbell , Rob Herring , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Thu, Oct 31, 2013 at 10:15:26AM +0100, Denis Carikli wrote: > This is mostly cut and paste from the imx35 pinctrl driver. > The data was generated using sed and awk on > arch/arm/plat-mxc/include/mach/iomux-mx25.h. > = > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Stephen Warren > Cc: Ian Campbell > Cc: devicetree@vger.kernel.org > Cc: Sascha Hauer > Cc: linux-arm-kernel@lists.infradead.org > Cc: Russell King > Cc: Linus Walleij > Cc: Eric B=E9nard > Signed-off-by: Denis Carikli > --- > ChangeLog v8->v9: > - Whitespace cleanup betwen the CC: and Signed-off-by. > - Kconfig: rebased to make it apply on the new HEAD. > --- > .../bindings/pinctrl/fsl,imx25-pinctrl.txt | 33 ++ > arch/arm/boot/dts/imx25-pinfunc.h | 513 ++++++++++++++= ++++++ > arch/arm/boot/dts/imx25.dtsi | 1 + > arch/arm/mach-imx/Kconfig | 2 + > drivers/pinctrl/Kconfig | 8 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-imx25.c | 351 ++++++++++++++ > 7 files changed, 909 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx25-p= inctrl.txt > create mode 100644 arch/arm/boot/dts/imx25-pinfunc.h > create mode 100644 drivers/pinctrl/pinctrl-imx25.c > = > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.= txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt > new file mode 100644 > index 0000000..64906ca > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt > @@ -0,0 +1,33 @@ > +* Freescale IMX25 IOMUX Controller > + > +Please refer to fsl,imx-pinctrl.txt in this directory for common binding= part > +and usage. > + > +Required properties: > +- compatible: "fsl,imx25-iomuxc" > +- fsl,pins: two integers array, represents a group of pins mux and config > + setting. The format is fsl,pins =3D , PIN_FUNC_ID = is a > + pin working on a specific function, CONFIG is the pad setting value li= ke > + pull-up for this pin. Please refer to imx25 datasheet for the valid pad > + config settings. This description is wrong. We have a correct description of fsl,pins in Documentation/devicetree/bindings/pinctrl/fsl,imx-pinctrl.txt already, so we should probably refer to it instead of describing it again here. This is wrong in all Documentation/devicetree/bindings/pinctrl/fsl,imx?*-pinctrl.txt files in the tree currently. Otherwise: Acked-by: Sascha Hauer Sascha -- = Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |