From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Pargmann Subject: Re: [PATCHv11][ 4/7] pinctrl: pinctrl-imx: add imx25 pinctrl driver Date: Tue, 5 Nov 2013 15:56:02 +0100 Message-ID: <20131105145602.GF15098@pengutronix.de> References: <1383662354-22417-1-git-send-email-denis@eukrea.com> <1383662354-22417-4-git-send-email-denis@eukrea.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1383662354-22417-4-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Denis Carikli Cc: Shawn Guo , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sascha Hauer , Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Linus Walleij , Eric =?utf-8?Q?B=C3=A9nard?= List-Id: devicetree@vger.kernel.org On Tue, Nov 05, 2013 at 03:39:11PM +0100, Denis Carikli wrote: > This is mostly cut and paste from the imx35 pinctrl driver. > The data was generated using sed and awk on > arch/arm/plat-mxc/include/mach/iomux-mx25.h. >=20 > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Stephen Warren > Cc: Ian Campbell > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Sascha Hauer > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: Russell King > Cc: Linus Walleij > Cc: Eric B=C3=A9nard > Signed-off-by: Denis Carikli > Acked-by: Sascha Hauer > --- > ChangeLog v9->v10: > - Added a imx25-pingrp.h header. > - Removed backslash-newline at end of imx25-pingrp.h >=20 > ChangeLog v8->v9: > - Whitespace cleanup betwen the CC: and Signed-off-by. > - Kconfig: rebased to make it apply on the new HEAD. > --- > .../bindings/pinctrl/fsl,imx25-pinctrl.txt | 25 + > arch/arm/boot/dts/imx25-pinfunc.h | 494 ++++++++++= ++++++++++ > arch/arm/boot/dts/imx25-pingrp.h | 79 ++++ > arch/arm/boot/dts/imx25.dtsi | 1 + > drivers/pinctrl/Kconfig | 9 + > drivers/pinctrl/Makefile | 1 + > drivers/pinctrl/pinctrl-imx25.c | 351 ++++++++++= ++++ > 7 files changed, 960 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/fsl,imx= 25-pinctrl.txt > create mode 100644 arch/arm/boot/dts/imx25-pinfunc.h > create mode 100644 arch/arm/boot/dts/imx25-pingrp.h > create mode 100644 drivers/pinctrl/pinctrl-imx25.c >=20 > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinc= trl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.t= xt > new file mode 100644 > index 0000000..1d6dae2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx25-pinctrl.txt > @@ -0,0 +1,25 @@ > +* Freescale IMX25 IOMUX Controller > + > +Please refer to fsl,imx-pinctrl.txt in this directory for common bin= ding part > +and usage. > + > +CONFIG bits definition: > +PAD_CTL_DRIVE_VOLAGAGE_18 (1 << 13) > +PAD_CTL_DRIVE_VOLAGAGE_33 (0 << 13) > +PAD_CTL_HYS (1 << 8) > +PAD_CTL_PKE (1 << 7) > +PAD_CTL_PUE (1 << 6) > +PAD_CTL_PUS_100K_DOWN (0 << 4) > +PAD_CTL_PUS_47K_UP (1 << 4) > +PAD_CTL_PUS_100K_UP (2 << 4) > +PAD_CTL_PUS_22K_UP (3 << 4) > +PAD_CTL_ODE_CMOS (0 << 3) > +PAD_CTL_ODE_OPENDRAIN (1 << 3) > +PAD_CTL_DSE_NOMINAL (0 << 1) > +PAD_CTL_DSE_HIGH (1 << 1) > +PAD_CTL_DSE_MAX (2 << 1) > +PAD_CTL_SRE_FAST (1 << 0) > +PAD_CTL_SRE_SLOW (0 << 0) You removed the group control registers in v11? Are these config bits used for other pinctl registers? Especially "DRIVE_VOLTAGE" seems to be only for those registers you removed. Regards Markus Pargmann --=20 Pengutronix e.K. | = | Industrial Linux Solutions | http://www.pengutronix.de/= | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 = | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555= 5 | -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html