From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v4 05/31] mtd: nand: pxa3xx: devicetree binding update Date: Thu, 7 Nov 2013 13:41:33 -0300 Message-ID: <20131107164132.GA30917@localhost> References: <1383837455-30721-1-git-send-email-ezequiel.garcia@free-electrons.com> <1383837455-30721-6-git-send-email-ezequiel.garcia@free-electrons.com> <20131107153210.GK8308@titan.lakedaemon.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20131107153210.GK8308-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Cooper Cc: linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lior Amsalem , Tawfik Bayouk , Thomas Petazzoni , Gregory Clement , Brian Norris , Huang Shijie , Willy Tarreau , Daniel Mack List-Id: devicetree@vger.kernel.org On Thu, Nov 07, 2013 at 10:32:10AM -0500, Jason Cooper wrote: > On Thu, Nov 07, 2013 at 12:17:09PM -0300, Ezequiel Garcia wrote: > > Since the driver supports the new compatible string, the binding > > documentation must be updated to reflect it. > >=20 > > Signed-off-by: Ezequiel Garcia > > --- > > Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > Thanks for adding this, but please remember to update the Subject > string in the future. Both this patch and the next one are changing = the > Documentation/ portion of the tree, not drivers/. >=20 Come again? You mean "[PATCH] Documentation: mtd: nand: Do this" In that case: sorry, I do it differently on purpose, it looks better to me (focus the affected driver), but maybe I'm wrong. > And, >=20 > Acked-by: Jason Cooper >=20 Thanks! > thx, >=20 > Jason. >=20 > > diff --git a/Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt = b/Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt > > index f1421e2..bed8390 100644 > > --- a/Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt > > +++ b/Documentation/devicetree/bindings/mtd/pxa3xx-nand.txt > > @@ -2,7 +2,9 @@ PXA3xx NAND DT bindings > > =20 > > Required properties: > > =20 > > - - compatible: Should be "marvell,pxa3xx-nand" > > + - compatible: Should be set to one of the following: > > + marvell,pxa3xx-nand > > + marvell,armada370-nand > > - reg: The register base for the controller > > - interrupts: The interrupt to map > > - #address-cells: Set to <1> if the node includes partitions > > --=20 > > 1.8.1.5 > >=20 --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html