From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Valentine Barshak <valentine.barshak@cogentembedded.com>,
linux-sh@vger.kernel.org, linux-ide@vger.kernel.org,
devicetree@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Kumar Gala <galak@codeaurora.org>, Tejun Heo <tj@kernel.org>,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH V2 2/2] dt: Document sata_rcar bindings
Date: Fri, 8 Nov 2013 18:01:35 +0900 [thread overview]
Message-ID: <20131108090126.GA9467@verge.net.au> (raw)
In-Reply-To: <874n7nquh4.wl%kuninori.morimoto.gx@renesas.com>
On Thu, Nov 07, 2013 at 10:27:08PM -0800, Kuninori Morimoto wrote:
>
> Hi Laurent, Simon
>
> One question
>
> > > +- interrupts : must consist of one interrupt specifier.
> > > +
> > > +Example:
> > > +
> > > +sata: sata@fc600000 {
> > > + compatible = "renesas,sata-r8a7779";
> > > + reg = <0xfc600000 0x2000>;
> > > + interrupt-parent = <&gic>;
> > > + interrupts = <0 100 0x4>;
> >
> > Please use IRQ_TYPE_LEVEL_HIGH instead of 0x4.
>
> Now, our many SoC codes are using 0x4 in "interrupts".
> Do you think we should use IRQ_TYPE_LEVEL_HIGH ?
Personally I think that would be nice.
next prev parent reply other threads:[~2013-11-08 9:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 20:04 [PATCH V2 0/2] sata_rcar: Add Gen2 PHY support and document existing DT bindings Valentine Barshak
2013-11-07 20:04 ` [PATCH V2 1/2] sata_rcar: Add R-Car Gen2 SATA PHY support Valentine Barshak
2013-11-07 20:13 ` Valentine
2013-11-07 20:04 ` [PATCH V2 2/2] dt: Document sata_rcar bindings Valentine Barshak
2013-11-08 1:02 ` Laurent Pinchart
2013-11-08 6:27 ` Kuninori Morimoto
2013-11-08 9:01 ` Simon Horman [this message]
2013-11-08 11:26 ` Valentine
2013-11-08 11:52 ` Valentine
2013-11-08 15:31 ` Laurent Pinchart
2013-11-12 3:42 ` Simon Horman
2013-11-12 13:46 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131108090126.GA9467@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
--cc=valentine.barshak@cogentembedded.com \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).