Re: [PATCH] ARM: mvebu: Add Netgear ReadyNAS 2120 board

[Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>]

On Sat, Nov 09, 2013 at 09:27:32PM +0100, Arnaud Ebalard wrote:
> 
> All hardware parts of the (mv78230 Armada XP based) NETGEAR ReadyNAS
> 2120 are supported by mainline kernel (USB 3.0 and eSATA rear ports,
> USB 2.0 front port, Gigabit controller and PHYs for the two rear ports,
> serial port, LEDs, Buttons, 88SE9170 SATA controllers, three G762 fan
> controllers, G751 temperature sensor) except for:

> +			i2c@11000 {
> +				compatible = "marvell,mv64xxx-i2c";
> +				clock-frequency = <400000>;
> +				status = "okay";
> +
> +				/* Rear fan #1 of 3 (Protechnic MGT4012XB-O20,
> +				 * 8000RPM) near eSATA port */
> +				g762_fan1: g762@3e {
> +					compatible = "gmt,g762";
> +					reg = <0x3e>;
> +					clocks = <&g762_clk>; /* input clock */
> +					fan_gear_mode = <0>;
> +					fan_startv = <1>;
> +					pwm_polarity = <0>;
> +				};
> +
> +				/* Rear fan #2 of 3 at the center */
> +				g762_fan2: g762@48 {
> +					compatible = "gmt,g762";
> +					reg = <0x48>;
> +					clocks = <&g762_clk>; /* input clock */
> +					fan_gear_mode = <0>;
> +					fan_startv = <1>;
> +					pwm_polarity = <0>;
> +				};
> +
> +				/* Rear fan #3 of 3 */
> +				g762_fan3: g762@49 {
> +					compatible = "gmt,g762";
> +					reg = <0x49>;
> +					clocks = <&g762_clk>; /* input clock */
> +					fan_gear_mode = <0>;
> +					fan_startv = <1>;
> +					pwm_polarity = <0>;
> +				};
> +
> +				g751: g751@4c {
> +					compatible = "gmt,g751";
> +					reg = <0x4c>;
> +				};

Hi Arnaud

Looks good to me. However, if for some reason you need to respin, it
would be nice to add a comment about what the g751 is. All the other
i2c devices you say what they are. No need to respin just because of
this.

	Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html