From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH] ARM: mvebu: Add Netgear ReadyNAS 2120 board Date: Sun, 10 Nov 2013 09:15:33 +0100 Message-ID: <20131110091533.463cabb2@skate> References: <87bo1tmibv.fsf@natisbad.org> <527ECBDD.7050607@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <527ECBDD.7050607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sebastian Hesselbarth Cc: Arnaud Ebalard , Jason Cooper , Andrew Lunn , Gregory Clement , Ezequiel Garcia , Russell King , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Guenter Roeck List-Id: devicetree@vger.kernel.org Dear Sebastian Hesselbarth, On Sun, 10 Nov 2013 00:57:17 +0100, Sebastian Hesselbarth wrote: > > arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 289 +++++++++++++++++++++++++ > > Arnaud, > > thanks for providing this! I do have some comments below. > > we recently had a discussion about the naming of new DTS files, which > proposes to name those after vendor,board.dts (or vendor-board.dts). > > I personally prefer vendor,board.dts which would give > netgear,readynas-2120.dts based on your compatible below. > The final call for ',' vs '-' has not been made, so I suggest Jason > makes a call here. Hum, do we really want that? The current naming scheme is really, really great, because whenever you want to grep through all Armada 370/XP DTS, you just have to use armada-*, for all Kirkwood, kirkwood-*. I've found this very very convenient to verify the coherency between .dts/.dtsi for a given family of SoCs. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html