From: Grant Likely <grant.likely@secretlab.ca>
To: Florian Fainelli <f.fainelli@gmail.com>,
Jonas Jensen <jonas.jensen@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] phy: Add MOXA RTL8201CP PHY support
Date: Mon, 11 Nov 2013 15:30:02 +0000 [thread overview]
Message-ID: <20131111153002.722CCC4191F@trevor.secretlab.ca> (raw)
In-Reply-To: <CAGVrzcZW=CLWPZgRqkqR1wNh+S7dfwRZAzn1Uq7Ji6K0=iGYtg@mail.gmail.com>
On Mon, 4 Nov 2013 09:51:24 -0800, Florian Fainelli <f.fainelli@gmail.com> wrote:
> 2013/11/4 Jonas Jensen <jonas.jensen@gmail.com>:
> > This is why I ended up setting PHY_IGNORE_INTERRUPT and the comment
> > about its effectiveness. Polling works but the extra reads on the bus
> > seem unnecessary.
> > Ideas how they can be eliminated are appreciated.
>
> As of today, the only way to work around it is not to use
> of_mdiobus_register() and use mdiobus_register() directly which will
> allow you to properly describe such a configuration.
of_mdiobus_register() can be changed. One option: If the caller knows
what it wants to happen in the case of no interrupt, then it can be
added as an argument to of_mdiobus_register(). No need to work around
this in an ugly way.
Is setting the irq to PHY_POLL something that should be done for the
entire bus, or only for a handful of PHYs?
g.
next prev parent reply other threads:[~2013-11-11 15:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-01 14:54 [PATCH] phy: Add MOXA RTL8201CP PHY support Jonas Jensen
[not found] ` <1383317673-14704-1-git-send-email-jonas.jensen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-11-01 17:01 ` Florian Fainelli
[not found] ` <CAGVrzcYfdChFNgkh=VAFZQfCRHyNTe_pZxx1Z6Sz1S8_1vzgtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-04 13:50 ` Jonas Jensen
[not found] ` <CACmBeS3aUq_yPVg_GaKmQRQMhAmO8RZVzUGY=T6Ghn7v0sP8Dw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-11-04 17:51 ` Florian Fainelli
2013-11-11 15:30 ` Grant Likely [this message]
2013-11-01 17:17 ` Kishon Vijay Abraham I
2013-11-02 18:05 ` Grant Likely
2013-11-05 15:55 ` [PATCH v2] phy: Add MOXA MDIO driver Jonas Jensen
2013-11-07 20:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131111153002.722CCC4191F@trevor.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jonas.jensen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).