Re: [PATCH] ARM: dts: AM437x GP EVM support

From: Felipe Balbi <balbi@ti.com>
To: Afzal Mohammed <afzal@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Rajendra Nayak <rnayak@ti.com>,
	Russell King <linux@arm.linux.org.uk>,
	Benoit Cousson <bcousson@baylibre.com>,
	Pawel Moll <pawel.moll@arm.com>,
	linux-doc@vger.kernel.org, Lokesh Vutla <lokeshvutla@ti.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	balbi@ti.com, Rob Herring <rob.herring@calxeda.com>,
	Rob Landley <rob@landley.net>,
	Sourav Poddar <sourav.poddar@ti.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: AM437x GP EVM support
Date: Wed, 13 Nov 2013 06:44:23 -0600	[thread overview]
Message-ID: <20131113124423.GA28192@saruman.home> (raw)
In-Reply-To: <5283247D.7010106@ti.com>

[-- Attachment #1.1: Type: text/plain, Size: 1254 bytes --]

On Wed, Nov 13, 2013 at 12:34:29PM +0530, Afzal Mohammed wrote:
> Hi Felipe,
> 
> On Tuesday 12 November 2013 07:52 PM, Felipe Balbi wrote:
> > On Tue, Nov 12, 2013 at 04:54:26PM +0530, Afzal Mohammed wrote:
> >> From: Lokesh Vutla <lokeshvutla@ti.com>
> 
> >> AM437x GP EVM DTS with pinmux information to make I2C on EVM usable.
> >>
> >> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> >> Signed-off-by: Sourav Poddar <sourav.poddar@ti.com>
> >> Signed-off-by: Afzal Mohammed <afzal@ti.com>
> 
> > could you instead send the much more complete version we already have
> > at [1] ? It's pointless to repatch all of that in this file if we *know*
> > those are already working.
> 
> By taking those changes and testing on mainline, I couldn't get mmc
> working and was not confident about ethernet changes, I2C changes were
> verified and boot test was done (with DT clock series). I posted only
> the changes that I felt confident.
> 
> Basic DT file and I2C are dependency for others, it was necessary to
> remove dependencies at the earliest.

fair enough, still sounds weird not to send the full DTS considering
it won't cause regressions, it just exposes an existing failure WRT
AM437x support upstream.

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel