From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCHv8][ 4/5] ARM: dts: Add support for the cpuimx35 board from Eukrea and its baseboard. Date: Wed, 13 Nov 2013 23:23:07 +0800 Message-ID: <20131113152305.GD17816@S2101-09.ap.freescale.net> References: <1384255459-15134-1-git-send-email-denis@eukrea.com> <1384255459-15134-4-git-send-email-denis@eukrea.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1384255459-15134-4-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Denis Carikli Cc: Sascha Hauer , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Grant Likely , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eric =?iso-8859-1?Q?B=E9nard?= List-Id: devicetree@vger.kernel.org On Tue, Nov 12, 2013 at 12:24:18PM +0100, Denis Carikli wrote: > The following devices/functionalities were added: > * Main and secondary UARTs. > * i2c and the pcf8563 device. > * Ethernet. > * NAND. > * The BP1 button. > * The LED. > * Watchdog > * SD. >=20 > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Stephen Warren > Cc: Ian Campbell > Cc: Grant Likely > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > Cc: Eric B=E9nard > Signed-off-by: Denis Carikli > Acked-by: Sascha Hauer > --- > ChangeLog v7->v8: > - The commit message was improved. > - The board specific iomuxc pins group configuration that were in imx= 35.dtsi were moved here. > - The rest of the patch was updated accordingly. >=20 > ChangeLog v6->v7: > - Added Grant Likely in the Cc list. > - Shortened the license. > - The tsc2007 pads were moved in another patch. >=20 > ChangeLog v5->v6: > - Shawn Guo was added in the Cc. > --- > arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi | 58 +++++++++ > .../boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts | 124 ++++++++++= ++++++++++ > 2 files changed, 182 insertions(+) > create mode 100644 arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi > create mode 100644 arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboar= d.dts Please add the dtb target into arch/arm/boot/dts/Makefile. >=20 > diff --git a/arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi b/arch/arm/= boot/dts/imx35-eukrea-cpuimx35.dtsi > new file mode 100644 > index 0000000..3260678 > --- /dev/null > +++ b/arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi > @@ -0,0 +1,58 @@ > +/* > + * Copyright 2013 Eukr=E9a Electromatique > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version 2 > + * of the License, or (at your option) any later version. > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include "imx35.dtsi" > + > +/ { > + model =3D "Eukrea CPUIMX35"; > + compatible =3D "eukrea,cpuimx35", "fsl,imx35"; > + > + memory { > + reg =3D <0x80000000 0x8000000>; /* 128M */ > + }; > +}; > + > +&fec { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_fec>; > + status =3D "okay"; > +}; > + > +&i2c1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_i2c1>; > + status =3D "okay"; Nit: have a blank line here. > + pcf8563@51 { > + compatible =3D "nxp,pcf8563"; > + reg =3D <0x51>; > + }; > +}; > + > +&iomuxc { > + imx35-eukrea { > + pinctrl_fec: fecgrp { > + fsl,pins =3D ; > + }; > + > + pinctrl_i2c1: i2c1grp { > + fsl,pins =3D ; > + }; > + }; > +}; > + > +&nfc { > + nand-bus-width =3D <8>; > + nand-ecc-mode =3D "hw"; > + nand-on-flash-bbt; > + status =3D "okay"; > +}; > diff --git a/arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts b= /arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts > new file mode 100644 > index 0000000..fe0f3fa > --- /dev/null > +++ b/arch/arm/boot/dts/imx35-eukrea-mbimxsd35-baseboard.dts > @@ -0,0 +1,124 @@ > +/* > + * Copyright 2013 Eukr=E9a Electromatique > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License > + * as published by the Free Software Foundation; either version 2 > + * of the License, or (at your option) any later version. > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +/dts-v1/; > +#include "imx35-eukrea-cpuimx35.dtsi" > + > +/ { > + model =3D "Eukrea CPUIMX35"; > + compatible =3D "eukrea,mbimxsd35-baseboard", "eukrea,cpuimx35", "fs= l,imx35"; > + > + gpio_keys { > + compatible =3D "gpio-keys"; > + > + bp1 { > + label =3D "BP1"; > + gpios =3D <&gpio3 25 1>; > + linux,code =3D <256>; > + gpio-key,wakeup; > + linux,input-type =3D <1>; > + }; > + }; > + > + leds { > + compatible =3D "gpio-leds"; > + > + led1 { > + label =3D "led1"; > + gpios =3D <&gpio3 29 1>; > + linux,default-trigger =3D "heartbeat"; > + }; > + }; > +}; > + > +&audmux { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_audmux>; > + status =3D "okay"; > +}; > + > +&esdhc1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_esdhc1>; > + cd-gpios =3D <&gpio3 24 0>; > + status =3D "okay"; > +}; > + > +&i2c1 { > + tlv320aic23: codec@1a { > + compatible =3D "ti,tlv320aic23"; > + reg =3D <0x1a>; > + }; > +}; > + > +&iomuxc { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_hog>; Use tab instead of spaces. > + > + imx35-eukrea { > + pinctrl_hog: hoggrp { > + fsl,pins =3D < > + MX35_PAD_LD18__GPIO3_24 0x80000000 > + MX35_PAD_LD19__GPIO3_25 0x80000000 > + MX35_PAD_LD23__GPIO3_29 0x80000000 > + >; > + }; > + > + pinctrl_audmux: audmuxgrp { > + fsl,pins =3D ; > + }; > + > + pinctrl_esdhc1: esdhc1grp { > + fsl,pins =3D ; > + }; > + > + pinctrl_fec: fecgrp { > + fsl,pins =3D ; > + }; > + > + pinctrl_i2c1: i2c1grp { > + fsl,pins =3D ; > + }; > + > + pinctrl_reg_lcd_3v3: reg_lcd_3v3 { '_' is used in label while '-' should be used in node name. Shawn > + fsl,pins =3D ; > + }; > + > + pinctrl_uart1: uart1grp { > + fsl,pins =3D ; > + }; > + > + pinctrl_uart2: uart2grp { > + fsl,pins =3D ; > + }; > + }; > +}; > + > +&ssi1 { > + fsl,mode =3D "i2s-slave"; > + status =3D "okay"; > +}; > + > +&uart1 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_uart1>; > + fsl,uart-has-rtscts; > + status =3D "okay"; > +}; > + > +&uart2 { > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&pinctrl_uart2>; > + fsl,uart-has-rtscts; > + status =3D "okay"; > +}; > --=20 > 1.7.9.5 >=20 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html