devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	Brian Austin <brian.austin@cirrus.com>,
	alsa-devel@alsa-project.org, rob.herring@calxeda.com,
	lgirdwood@gmail.com
Subject: Re: [PATCH v2 2/2] dt: binding: sound cs42l52 driver
Date: Wed, 13 Nov 2013 19:49:15 +0000	[thread overview]
Message-ID: <20131113194915.GF878@sirena.org.uk> (raw)
In-Reply-To: <1799362.QSDMu6GHtU@flatron>


[-- Attachment #1.1: Type: text/plain, Size: 831 bytes --]

On Wed, Nov 13, 2013 at 07:24:04PM +0100, Tomasz Figa wrote:

> Well, the label is just for the parser and it does not get into the DTB.
> This is where the DTS author can make things up just for their own
> convenience (like main_codec, aux_codec or even cs42l52). 

If only we could have comments :)

> I know this is really more bikeshedding than anything useful, but I'd
> rather try to follow the written rules in ePAPR, instead of nothing at
> all. At least just to make things more consistent.

My feeling here is that we should be looking more critically at ePAPR -
if we're picking people up for having what's essentially a comment
that's too specific we're probably doing something wrong especially
since the corrected example would look something like:

	codec: codec@12 {

which is a bit redundant.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



  reply	other threads:[~2013-11-13 19:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 15:44 [PATCH v2 1/2] ASoC: cs42l52: Add DeviceTree Support for CS42L52 Brian Austin
     [not found] ` <1384357474-28653-1-git-send-email-brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
2013-11-13 15:44   ` [PATCH v2 2/2] dt: binding: sound cs42l52 driver Brian Austin
     [not found]     ` <1384357474-28653-2-git-send-email-brian.austin-jGc1dHjMKG3QT0dZR+AlfA@public.gmane.org>
2013-11-13 15:53       ` Kumar Gala
     [not found]         ` <9097292C-9233-49B3-995D-27574D544237-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-11-13 16:21           ` Brian Austin
2013-11-13 16:33       ` Tomasz Figa
2013-11-13 16:43         ` Mark Brown
     [not found]           ` <20131113164328.GW878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-13 16:47             ` Tomasz Figa
2013-11-13 18:16               ` Mark Brown
     [not found]                 ` <20131113181622.GZ878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-13 18:24                   ` Tomasz Figa
2013-11-13 19:49                     ` Mark Brown [this message]
     [not found]                       ` <20131113194915.GF878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-11-13 20:13                         ` Tomasz Figa
2013-11-13 18:58         ` Brian Austin
     [not found]           ` <alpine.DEB.2.10.1311131248290.28828-QCF2GsvuTPME07tKKVU2gpqQE7yCjDx5@public.gmane.org>
2013-11-13 19:01             ` Tomasz Figa
2013-11-13 19:10               ` Brian Austin
     [not found]                 ` <alpine.DEB.2.10.1311131306150.28828-QCF2GsvuTPME07tKKVU2gpqQE7yCjDx5@public.gmane.org>
2013-11-13 19:29                   ` Tomasz Figa
2013-11-13 20:24                     ` Brian Austin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131113194915.GF878@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=brian.austin@cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=rob.herring@calxeda.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).