From: Arnd Bergmann <arnd@arndb.de>
To: Loc Ho <lho@apm.com>
Cc: olof@lixom.net, tj@kernel.org, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jcm@redhat.com,
Tuan Phan <tphan@apm.com>, Suman Tripathi <stripathi@apm.com>
Subject: Re: [PATCH v3 2/4] Documentation: Add documentation for APM X-Gene SATA controllor DTS binding
Date: Fri, 15 Nov 2013 14:28:24 +0100 [thread overview]
Message-ID: <201311151428.25204.arnd@arndb.de> (raw)
In-Reply-To: <1384465153-29902-3-git-send-email-lho@apm.com>
On Thursday 14 November 2013, Loc Ho wrote:
> +Required properties:
> +- compatible : Shall be "apm,xgene-ahci"
> +- reg : First memory resource shall be the AHCI memory
> + resource.
> + Second memory resource shall be the host controller
> + memory resource.
> +- id : Controller ID (0 = first, 1 = second, 2 = third)
As in the PHY patch, it's probably best to drop the "id" property here and
describe the actual differences between the instances directly, either by
having distinct "compatible" properties for each model, or by adding binary
flags to tell about a capability that only some instances have.
Also, I think you should have a separate file for the sata binding, especially
since the PHY binding is not actually specific to SATA at all.
Aside from these, the binding looks good to me now.
Arnd
prev parent reply other threads:[~2013-11-15 13:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 21:39 [PATCH v3 0/4] ata: Add APM X-Gene SoC SATA host controller support Loc Ho
2013-11-14 21:39 ` [PATCH v3 1/4] ata: Export required functions by APM X-Gene SATA driver Loc Ho
2013-11-14 21:39 ` [PATCH v3 2/4] Documentation: Add documentation for APM X-Gene SATA controllor DTS binding Loc Ho
2013-11-14 21:39 ` [PATCH v3 3/4] ata: Add APM X-Gene SoC SATA host controller driver Loc Ho
2013-11-14 21:39 ` [PATCH v4 4/4] arm64: Add APM X-Gene SoC SATA DTS entries Loc Ho
2013-11-15 13:48 ` [PATCH v3 3/4] ata: Add APM X-Gene SoC SATA host controller driver Arnd Bergmann
2013-11-16 6:36 ` Loc Ho
2013-11-19 21:22 ` Loc Ho
2013-11-26 10:11 ` Kishon Vijay Abraham I
2013-11-26 16:41 ` Loc Ho
2013-11-27 5:52 ` Kishon Vijay Abraham I
2013-11-27 5:58 ` Loc Ho
2013-11-21 13:20 ` Arnd Bergmann
2013-11-21 19:01 ` Loc Ho
2013-11-15 13:28 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311151428.25204.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=stripathi@apm.com \
--cc=tj@kernel.org \
--cc=tphan@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).