From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCHv3] ASoC: Add support for BCM2835 Date: Mon, 18 Nov 2013 15:06:19 +0000 Message-ID: <20131118150619.GL30853@e106331-lin.cambridge.arm.com> References: <5289F9DF.8060406@koalo.de> <20131118141637.GI30853@e106331-lin.cambridge.arm.com> <528A232B.9070402@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <528A232B.9070402@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Lars-Peter Clausen Cc: devicetree , "alsa-devel@alsa-project.org" , Stephen Warren , Liam Girdwood , "linux-kernel@vger.kernel.org" , Mark Brown , Florian Meier , linux-rpi-kernel , dmaengine , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Mon, Nov 18, 2013 at 02:24:43PM +0000, Lars-Peter Clausen wrote: > On 11/18/2013 03:16 PM, Mark Rutland wrote: > > > >> +static void bcm2835_i2s_stop_clock(struct bcm2835_i2s_dev *dev) > >> +{ > >> + uint32_t clkreg; > > > > s/uint32_t/u32/ (and elsewhere...) > > Please don't do that. > I was under the impression that there was a preference for uXX types over uintXX_t types, but the replies and Documentation/CodingStyle have taught me otherwise. Apologies for the confusion here. Thanks, Mark.