From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCHv9][ 3/3] ARM: dts: cpuimx35 Add touchscreen support. Date: Thu, 21 Nov 2013 09:00:52 +0100 Message-ID: <20131121090052.1684db75@ipc1.ka-ro> References: <1383916659-9988-1-git-send-email-denis@eukrea.com> <1383916659-9988-3-git-send-email-denis@eukrea.com> <20131121050922.GF18477@ns203013.ovh.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20131121050922.GF18477@ns203013.ovh.net> Sender: linux-input-owner@vger.kernel.org To: Jean-Christophe PLAGNIOL-VILLARD Cc: Denis Carikli , Dmitry Torokhov , linux-input@vger.kernel.org, Tomi Valkeinen , linux-fbdev@vger.kernel.org, Shawn Guo , Sascha Hauer , devicetree@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Grant Likely , linux-arm-kernel@lists.infradead.org, Eric B??nard List-Id: devicetree@vger.kernel.org Hi, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 14:17 Fri 08 Nov , Denis Carikli wrote: > > Cc: Rob Herring > > Cc: Pawel Moll > > Cc: Mark Rutland > > Cc: Stephen Warren > > Cc: Ian Campbell > > Cc: Grant Likely > > Cc: devicetree@vger.kernel.org > > Cc: Dmitry Torokhov > > Cc: linux-input@vger.kernel.org > > Cc: Sascha Hauer > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: Lothar Wa=C3=9Fmann > > Cc: Shawn Guo > > Cc: Eric B=C3=A9nard > > Signed-off-by: Denis Carikli > > --- > > ChangeLog v8->v9: > > - Added Grant Likely in the cc list. > > - Adapted to the removal of the pinctrl properties in the tsc2007 d= ocumentation. > > - Fixed the gpios property (before, it was set to active high by er= ror). > >=20 > > ChangeLog v7->v8: > > - Added Shawn Guo in the cc list. > > --- > > arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi | 21 ++++++++++++++= +++++++ > > 1 file changed, 21 insertions(+) > >=20 > > diff --git a/arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi b/arch/ar= m/boot/dts/imx35-eukrea-cpuimx35.dtsi > > index b9cb5a5..f25a40f 100644 > > --- a/arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi > > +++ b/arch/arm/boot/dts/imx35-eukrea-cpuimx35.dtsi > > @@ -36,6 +36,27 @@ > > compatible =3D "nxp,pcf8563"; > > reg =3D <0x51>; > > }; > > + > > + tsc2007: tsc2007@48 { > > + compatible =3D "ti,tsc2007"; > > + reg =3D <0x48>; > > + interrupt-parent =3D <&gpio3>; > > + interrupts =3D <0x2 0x8>; > > + gpios =3D <&gpio3 2 1>; > as explain on the binding drop this gpios this is an IRQ not a gpio >=20 > NACK The driver needs an interrupt to get notified about pendown events and needs to poll the pendown signal to find out when the pen has been lifted. Both the interrupt and the pendown signal happen to be signalled on the same pin. Thus, IMO it is perfectly well to have the interrupt property as well as the gpios property here. How would you tell the driver which pin to poll for detecting the pen up event? Having a platform callback with hardcoded GPIO numbers is not an option= =2E Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html