From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH] of/platform: Fix no irq domain found errors when populating interrupts Date: Fri, 22 Nov 2013 17:08:51 -0800 Message-ID: <20131123010850.GN10023@atomide.com> References: <20131123004334.GJ10023@atomide.com> <20131123005509.GJ16735@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20131123005509.GJ16735@n2100.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Grant Likely , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org * Russell King - ARM Linux [131122 16:56]: > On Fri, Nov 22, 2013 at 04:43:35PM -0800, Tony Lindgren wrote: > > + /* See of_device_resource_notify for populating interrupts */ > > + for (i = 0; i < num_irq; i++, res++) { > > + res->flags = IORESOURCE_IRQ; > > + res->start = -EPROBE_DEFER; > > + res->end = -EPROBE_DEFER; > > NAK. Definitely a bad idea to start introducing magic values other into > resources. Please don't do this. Do you have any better ideas on how to sort out this issue then? Tony