From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-watchdog@vger.kernel.org, pawel.moll@arm.com,
swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk,
nsekhar@ti.com, galak@kernel.crashing.org,
rob.herring@calxeda.com, linux-kernel@vger.kernel.org,
wim@iguana.be, Santosh Shilimkar <santosh.shilimkar@ti.com>,
grant.likely@linaro.org,
"ivan.khoronzhuk" <ivan.khoronzhuk@ti.com>
Subject: Re: Fwd: [PATCH 6/8] watchdog: davinci: reuse driver for keystone arch
Date: Sat, 23 Nov 2013 19:02:02 +0100 [thread overview]
Message-ID: <201311231902.02807.arnd@arndb.de> (raw)
In-Reply-To: <527A28DE.4030906@ti.com>
On Wednesday 06 November 2013, ivan.khoronzhuk wrote:
> @@ -1,13 +1,20 @@
> -DaVinci Watchdog Timer (WDT) Controller
> +Texas Instruments DaVinci/Keystone Watchdog Timer (WDT) Controller
>
> Required properties:
> -- compatible : Should be "ti,davinci-wdt"
> +
> +- compatible: "ti,davinci-wdt"
> + "ti,keystone-wdt"
> +
> - reg : Should contain WDT registers location and length
>
...
> @@ -229,6 +229,7 @@ static int davinci_wdt_remove(struct platform_device *pdev)
>
> static const struct of_device_id davinci_wdt_of_match[] = {
> { .compatible = "ti,davinci-wdt", },
> + { .compatible = "ti,keystone-wdt", },
> {},
> };
> MODULE_DEVICE_TABLE(of, davinci_wdt_of_match);
You should clarify the compatible list here: It seems that the devices are fully
compatible, so the driver should only need to check for "ti,davinci-wdt" as the
compatible string, while the dtb files should list both "ti,davinci-wdt" and
"ti,keystone-wdt" for keystone, but only the davinci string for davinci.
Arnd
next prev parent reply other threads:[~2013-11-23 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1383680783-12114-7-git-send-email-ivan.khoronzhuk@ti.com>
2013-11-06 11:32 ` Fwd: [PATCH 6/8] watchdog: davinci: reuse driver for keystone arch ivan.khoronzhuk
[not found] ` <527A28DE.4030906-l0cyMroinI0@public.gmane.org>
2013-11-12 15:40 ` Santosh Shilimkar
2013-11-17 2:27 ` Guenter Roeck
[not found] ` <5288298B.1010602-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2013-11-18 15:03 ` ivan.khoronzhuk
2013-11-23 18:02 ` Arnd Bergmann [this message]
[not found] ` <201311231902.02807.arnd-r2nGTMty4D4@public.gmane.org>
2013-11-25 11:09 ` ivan.khoronzhuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201311231902.02807.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@kernel.crashing.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.khoronzhuk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).