From: Pavel Machek <pavel@ucw.cz>
To: Sebastian Reichel <sre@debian.org>
Cc: "Sebastian Reichel" <sre@ring0.de>,
"Anton Vorontsov" <anton@enomsg.org>,
"David Woodhouse" <dwmw2@infradead.org>,
"Rob Herring" <rob.herring@calxeda.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Rob Landley" <rob@landley.net>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, "Pali Rohár" <pali.rohar@gmail.com>,
freemangordon@abv.bg, aaro.koskinen@iki.fi
Subject: Re: [PATCH 3/3] dt: binding documentation for bq2415x charger
Date: Mon, 25 Nov 2013 14:07:00 +0100 [thread overview]
Message-ID: <20131125130700.GC21526@amd.pavel.ucw.cz> (raw)
In-Reply-To: <1385311771-447-4-git-send-email-sre@debian.org>
On Sun 2013-11-24 17:49:31, Sebastian Reichel wrote:
> Add devicetree binding documentation for bq2415x charger.
>
> Signed-off-by: Sebastian Reichel <sre@debian.org>
Thanks!
> +- reg: integer, i2c address of the device
> +- ti,current-limit: integer, current limit in mA
Does this need to be "ti," specific? Most of fields are likely to be
needed for other li-ion chargers....
"Specifies maximum current charger can pull from power supply"
?
> +- ti,charge-current: integer, charging current in mA
...why/how is it different from current-limit? Is the current-limit on
5V, while the charge-current relative to battery voltage... so that
charge-current can be > current-limit when battery voltage is low?
"Maximum current that will be supplied to the battery, as determined
by voltage on current sense resistor"?
> +- ti,weak-battery-voltage: integer, weak battery voltage threshold in mV
It would be good to explain what this threshold means. Voltage so low
that system needs to be shut down?
Hmm, it looks to me like it is "as long as battery is below this
voltage, fast charge is not started. Instead, slow 'precharge' is
performed."
> +- ti,battery-regulation-voltage: integer, battery regulation
> voltage in mV
"Selects maximum voltage for charging."
> +- ti,termination-current: integer, termination current in mA
"When current in constant-voltage phase drops below this value, charge
is terminated".
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2013-11-25 13:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-24 16:49 [PATCH 0/3] DT support for bq2415x Sebastian Reichel
2013-11-24 16:49 ` [PATCH 1/3] power_supply: add power_supply_get_by_phandle Sebastian Reichel
2013-11-25 12:32 ` Pavel Machek
[not found] ` <1385311771-447-2-git-send-email-sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2013-12-24 2:20 ` Anton Vorontsov
2013-12-24 3:37 ` Sebastian Reichel
2013-11-24 16:49 ` [PATCH 2/3] bq2415x_charger: add DT support Sebastian Reichel
2013-11-25 12:39 ` Pavel Machek
2013-11-24 16:49 ` [PATCH 3/3] dt: binding documentation for bq2415x charger Sebastian Reichel
2013-11-25 13:07 ` Pavel Machek [this message]
2013-12-24 2:20 ` [PATCH 0/3] DT support for bq2415x Anton Vorontsov
2013-12-24 3:39 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125130700.GC21526@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=anton@enomsg.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=freemangordon@abv.bg \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pali.rohar@gmail.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).