From: Felipe Balbi <balbi@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: balbi@ti.com, gregkh@linuxfoundation.org,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, rob@landley.net,
bcousson@baylibre.com, tony@atomide.com, linux@arm.linux.org.uk,
grant.likely@linaro.org, s.nawrocki@samsung.com,
galak@codeaurora.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/7] usb: dwc3: get "usb_phy" only if the platform indicates the presence of PHY's
Date: Mon, 25 Nov 2013 15:32:13 -0600 [thread overview]
Message-ID: <20131125213213.GV18046@saruman.home> (raw)
In-Reply-To: <5280EB5C.1040001@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1013 bytes --]
Hi,
On Mon, Nov 11, 2013 at 08:06:12PM +0530, Kishon Vijay Abraham I wrote:
> >> diff --git a/drivers/usb/dwc3/platform_data.h b/drivers/usb/dwc3/platform_data.h
> >> index 7db34f0..49ffa6d 100644
> >> --- a/drivers/usb/dwc3/platform_data.h
> >> +++ b/drivers/usb/dwc3/platform_data.h
> >> @@ -24,4 +24,6 @@ struct dwc3_platform_data {
> >> enum usb_device_speed maximum_speed;
> >> enum usb_dr_mode dr_mode;
> >> bool tx_fifo_resize;
> >> + bool usb2_phy;
> >> + bool usb3_phy;
> >
> > This would look better as a quirks flag, then we could:
> >
> > unsigned long quirks;
> > #define DWC3_QUIRK_NO_USB3_PHY BIT(0)
> > #define DWC3_QUIRK_NO_USB2_PHY BIT(1)
>
> Should this quirk be used for dt also? Currently we find if it has usb3 phy or
> usb2 phy from the dt data only. But if we add a quirk, we'll have to add a
> property to populate the quirk no?
either we use the quirk, or use the fact that no <&usb2_phy> phandle is
defined, would work both ways, no ?
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-25 21:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 19:54 [PATCH v2 0/7] Make dwc3 use Generic PHY Framework Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 1/7] usb: dwc3: get "usb_phy" only if the platform indicates the presence of PHY's Kishon Vijay Abraham I
2013-10-16 13:03 ` Roger Quadros
2013-10-16 13:10 ` Kishon Vijay Abraham I
2013-10-16 13:27 ` Roger Quadros
2013-10-17 14:54 ` Felipe Balbi
2013-12-03 10:39 ` Heikki Krogerus
2013-12-06 20:15 ` Felipe Balbi
2013-12-09 8:52 ` Heikki Krogerus
2013-12-12 18:27 ` Felipe Balbi
2013-11-05 18:11 ` Vivek Gautam
2013-11-05 18:12 ` Vivek Gautam
2013-10-17 16:38 ` Felipe Balbi
2013-10-21 11:56 ` Kishon Vijay Abraham I
2013-11-11 14:36 ` Kishon Vijay Abraham I
2013-11-25 21:32 ` Felipe Balbi [this message]
2013-12-03 9:50 ` Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 2/7] usb: dwc3: adapt dwc3 core to use Generic PHY Framework Kishon Vijay Abraham I
2013-10-16 13:18 ` Roger Quadros
2013-10-16 13:52 ` Kishon Vijay Abraham I
2013-10-16 14:23 ` Roger Quadros
2013-10-21 11:55 ` Kishon Vijay Abraham I
2013-10-21 12:13 ` Roger Quadros
[not found] ` <1381866857-3861-3-git-send-email-kishon-l0cyMroinI0@public.gmane.org>
2013-12-03 11:59 ` Heikki Krogerus
2013-12-03 14:13 ` Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 3/7] Documentation: dt bindings: move ..usb/usb-phy.txt to ..phy/ti-phy.txt Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 4/7] drivers: phy: usb3/pipe3: Adapt pipe3 driver to Generic PHY Framework Kishon Vijay Abraham I
2013-10-16 13:40 ` Roger Quadros
2013-10-21 12:53 ` Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 5/7] usb: phy: omap-usb2: remove *set_suspend* callback from omap-usb2 Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 6/7] phy: omap-usb2: move omap_usb.h from linux/usb/ to linux/phy/ Kishon Vijay Abraham I
2013-10-15 19:54 ` [PATCH v2 7/7] arm/dts: added dt properties to adapt to the new phy framwork Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131125213213.GV18046@saruman.home \
--to=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=s.nawrocki@samsung.com \
--cc=swarren@wwwdotorg.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).