From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577
Date: Wed, 27 Nov 2013 16:13:23 +0000 [thread overview]
Message-ID: <20131127161323.GS3296@lee--X1> (raw)
In-Reply-To: <20131127154221.GZ14725@sirena.org.uk>
On Wed, 27 Nov 2013, Mark Brown wrote:
> On Wed, Nov 27, 2013 at 03:23:58PM +0000, Lee Jones wrote:
> > On Wed, 27 Nov 2013, Mark Brown wrote:
> > > > + {
> > > > + .name = "max14577-regulator",
> > > > + .of_compatible = "maxim,max14577-regulator",
> > > > + },
>
> > > Why is there a compatible for this at all, would this ever appear as
> > > part of a different device?
>
> > For automatic assigning of it's of_node.
>
> > In previous incarnations of this set it was done manually for some reason.
>
> The usual thing to do is of_get_child_by_name() on the parent to get the
> container to search in.
What do you mean when you say 'usual thing'? Only the max8998 does
this currently. IMHO the better way to do it for MFD devices is
provide a compatible string and let the framework does the rest for
you.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-11-27 16:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 13:46 [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577 Krzysztof Kozlowski
[not found] ` <1385559982-32039-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2013-11-27 13:46 ` [PATCH v5 2/2] mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2013-11-27 13:59 ` [PATCH v5 1/2] regulator: max14577: Add regulator driver for Maxim 14577 Lee Jones
2013-11-27 15:20 ` Mark Brown
2013-11-27 15:23 ` Lee Jones
2013-11-27 15:42 ` Mark Brown
2013-11-27 16:13 ` Lee Jones [this message]
2013-11-27 16:28 ` Mark Brown
2013-12-02 14:12 ` Krzysztof Kozlowski
2013-12-03 18:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131127161323.GS3296@lee--X1 \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.kozlowski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).