Re: [PATCH V4 1/6] clk: exynos-audss: convert to platform device

[Mike Turquette <mturquette@linaro.org>]

Quoting Padma Venkat (2013-11-25 22:29:44)
> Hi Mike and Kukjin,
> 
> On Tue, Oct 8, 2013 at 10:23 PM, Andrew Bresticker
> <abrestic@chromium.org> wrote:
> > Hi Mike and Kukjin,
> >
> > Any decisions regarding this patchset?  I believe all comments have
> > been addressed.
> >
> > Thanks,
> > Andrew
> 
> Any decisions on this patchset. These can be applied directly on
> linux-samsung tree.

For all of the clk parts:

Acked-by: Mike Turquette <mturquette@linaro.org>

I'm happy to take them in as part of a pull request.

Regards,
Mike

> 
> >
> > On Wed, Sep 25, 2013 at 2:12 PM, Andrew Bresticker
> > <abrestic@chromium.org> wrote:
> >> The Exynos AudioSS clock controller will later be modified to allow
> >> input clocks to be specified via device-tree in order to support
> >> multiple Exynos SoCs.  This will introduce a dependency on the core
> >> SoC clock controller being initialized first so that the AudioSS driver
> >> can look up its input clocks, but the order in which clock providers
> >> are probed in of_clk_init() is not guaranteed.  Since deferred probing
> >> is not supported in of_clk_init() and the AudioSS block is not the core
> >> controller, we can initialize it later as a platform device.
> >>
> >> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> >> Acked-by: Tomasz Figa <t.figa@samsung.com>
> >> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> >> ---
> >> Changes since v3:
> >>  - __init -> __exit for module exit function
> >>  - fixed nits from Sylwester
> >> Changes since v2:
> >>  - add error handling to probe callback
> >>  - fixed ordering of of_clk_{add,del}_provider
> >>  - fixed nits from Tomasz and Sylwester
> >> Changes since v1:
> >>  - add clk_unregister() calls to remove callback
> >>  - fixed minor nits from Tomasz
> >> ---
> 
> Thanks
> Padma