devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support
@ 2013-11-27 18:46 Jarkko Nikula
  2013-11-27 22:02 ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Jarkko Nikula @ 2013-11-27 18:46 UTC (permalink / raw)
  To: devicetree; +Cc: linux-omap, Benoît Cousson, Tony Lindgren, Jarkko Nikula

This adds typical McBSP2-TWL4030 audio description to the legacy
Beagle Board.

Signed-off-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
---
 arch/arm/boot/dts/omap3-beagle.dts | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts
index fa532aaacc68..1912c421e246 100644
--- a/arch/arm/boot/dts/omap3-beagle.dts
+++ b/arch/arm/boot/dts/omap3-beagle.dts
@@ -61,6 +61,14 @@
 		vcc-supply = <&hsusb2_power>;
 	};
 
+	sound {
+		compatible = "ti,omap-twl4030";
+		ti,model = "omap3beagle";
+
+		ti,mcbsp = <&mcbsp2>;
+		ti,codec = <&twl_audio>;
+	};
+
 	gpio_keys {
 		compatible = "gpio-keys";
 
@@ -120,6 +128,12 @@
 		reg = <0x48>;
 		interrupts = <7>; /* SYS_NIRQ cascaded to intc */
 		interrupt-parent = <&intc>;
+
+		twl_audio: audio {
+			compatible = "ti,twl4030-audio";
+			codec {
+			};
+		};
 	};
 };
 
-- 
1.8.4.3


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support
  2013-11-27 18:46 [PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support Jarkko Nikula
@ 2013-11-27 22:02 ` Tony Lindgren
  2013-11-28 17:04   ` Jarkko Nikula
  0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2013-11-27 22:02 UTC (permalink / raw)
  To: Jarkko Nikula; +Cc: devicetree, linux-omap, Benoît Cousson

* Jarkko Nikula <jarkko.nikula@bitmer.com> [131127 10:48]:
> This adds typical McBSP2-TWL4030 audio description to the legacy
> Beagle Board.

Nice to see that work almost out of the box :)

BTW, I just noticed that sound/soc/omap/Kconfig has depends on
OMAP_MUX. The OMAP_MUX option will be dropped for mach-omap2
for v3.14, so you may want to take a look at that too. If there
really is a dependency, that should be handled using
pinctrl-single for the .dts entries.

Regards,

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support
  2013-11-27 22:02 ` Tony Lindgren
@ 2013-11-28 17:04   ` Jarkko Nikula
  2013-12-02 19:16     ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Jarkko Nikula @ 2013-11-28 17:04 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: devicetree, linux-omap, Benoît Cousson

On 11/28/2013 12:02 AM, Tony Lindgren wrote:
> * Jarkko Nikula <jarkko.nikula@bitmer.com> [131127 10:48]:
>> This adds typical McBSP2-TWL4030 audio description to the legacy
>> Beagle Board.
> 
> Nice to see that work almost out of the box :)
> 
> BTW, I just noticed that sound/soc/omap/Kconfig has depends on
> OMAP_MUX. The OMAP_MUX option will be dropped for mach-omap2
> for v3.14, so you may want to take a look at that too. If there
> really is a dependency, that should be handled using
> pinctrl-single for the .dts entries.
> 
There is actually dependency but only on N810 which needs to remux 4
pins from EAC to McBSP2. I'll try to keep my eye on it but don't let
that block your cleanup work.

-- 
Jarkko

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support
  2013-11-28 17:04   ` Jarkko Nikula
@ 2013-12-02 19:16     ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2013-12-02 19:16 UTC (permalink / raw)
  To: Jarkko Nikula; +Cc: devicetree, linux-omap, Benoît Cousson

* Jarkko Nikula <jarkko.nikula@bitmer.com> [131128 09:05]:
> On 11/28/2013 12:02 AM, Tony Lindgren wrote:
> > * Jarkko Nikula <jarkko.nikula@bitmer.com> [131127 10:48]:
> >> This adds typical McBSP2-TWL4030 audio description to the legacy
> >> Beagle Board.
> > 
> > Nice to see that work almost out of the box :)
> > 
> > BTW, I just noticed that sound/soc/omap/Kconfig has depends on
> > OMAP_MUX. The OMAP_MUX option will be dropped for mach-omap2
> > for v3.14, so you may want to take a look at that too. If there
> > really is a dependency, that should be handled using
> > pinctrl-single for the .dts entries.
> > 
> There is actually dependency but only on N810 which needs to remux 4
> pins from EAC to McBSP2. I'll try to keep my eye on it but don't let
> that block your cleanup work.

Thanks, meanwhile I'll queue your beagle audio fix.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-12-02 19:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-27 18:46 [PATCH] ARM: dts: omap3-beagle: Add omap-twl4030 audio support Jarkko Nikula
2013-11-27 22:02 ` Tony Lindgren
2013-11-28 17:04   ` Jarkko Nikula
2013-12-02 19:16     ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).