From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH v5 08/17] clk: at91: add PMC system clocks Date: Wed, 27 Nov 2013 14:05:29 -0800 Message-ID: <20131127220529.16819.42204@quantum> References: <1384289513-3068-1-git-send-email-b.brezillon@overkiz.com> <1384293935-4755-1-git-send-email-b.brezillon@overkiz.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1384293935-4755-1-git-send-email-b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Andrew Victor , Nicolas Ferre , Jean-Christophe Plagniol-Villard , Russell King , Felipe Balbi , Greg Kroah-Hartman , Grant Likely , Ludovic Desroches , Josh Wu , Richard Genoud Cc: Boris BREZILLON , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Quoting Boris BREZILLON (2013-11-12 14:05:35) > This patch adds new at91 system clock implementation using common clk > framework. > > Some peripherals need to enable a "system" clock in order to work properly. > Each system clock is given an id based on the bit position in SCER/SCDR > registers. > > Signed-off-by: Boris BREZILLON > Acked-by: Nicolas Ferre > --- > drivers/clk/at91/Makefile | 1 + > drivers/clk/at91/clk-system.c | 137 +++++++++++++++++++++++++++++++++++++++++ > drivers/clk/at91/pmc.c | 5 ++ > drivers/clk/at91/pmc.h | 3 + > 4 files changed, 146 insertions(+) > create mode 100644 drivers/clk/at91/clk-system.c > > diff --git a/drivers/clk/at91/Makefile b/drivers/clk/at91/Makefile > index e28fb2b..c2b7068 100644 > --- a/drivers/clk/at91/Makefile > +++ b/drivers/clk/at91/Makefile > @@ -4,3 +4,4 @@ > > obj-y += pmc.o > obj-y += clk-main.o clk-pll.o clk-plldiv.o clk-master.o > +obj-y += clk-system.o > diff --git a/drivers/clk/at91/clk-system.c b/drivers/clk/at91/clk-system.c > new file mode 100644 > index 0000000..1c086f4 > --- /dev/null > +++ b/drivers/clk/at91/clk-system.c > @@ -0,0 +1,137 @@ > +/* > + * drivers/clk/at91/clk-system.c Nitpick: it's better to not put file paths in a comment block in case the file name or path is changed. Regards, Mike -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html