devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Rosenberger,
	Philipp" <Philipp.Rosenberger-wIELUdCntIg@public.gmane.org>
Cc: "linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Grant Likely
	<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] of_mtd: Fix header file include guard
Date: Fri, 29 Nov 2013 00:11:13 -0800	[thread overview]
Message-ID: <20131129081113.GA20013@norris.computersforpeace.net> (raw)
In-Reply-To: <52972EEE.8070704-wIELUdCntIg@public.gmane.org>

+ device tree guys

Hi Grant/Rob,

It looks like this header is technically owned by you guys. Once we have
a proper submission, should I merge this sort of change through MTD, or
do one of you want to take care of it?

Hi Philpp,

Thanks for the patch! There are a few things to fix up though.

On Thu, Nov 28, 2013 at 11:53:39AM +0000, Rosenberger, Philipp wrote:
> It seems the include guard was copied from of_net.h.

Good catch.

Note that all patches require a "Signed-off-by" line in the patch
description, to signify (among other things) that this is your work and
that you are submitting it under the GPLv2 license. See
Documentation/SubmittingPatches (esp. point 12).

> ---
>  include/linux/of_mtd.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/of_mtd.h b/include/linux/of_mtd.h
> index 6f10e93..cb32d9c 100644
> --- a/include/linux/of_mtd.h
> +++ b/include/linux/of_mtd.h
> @@ -7,7 +7,7 @@
>   */
> 
>  #ifndef __LINUX_OF_MTD_H
> -#define __LINUX_OF_NET_H
> +#define __LINUX_OF_MTD_H
> 
>  #ifdef CONFIG_OF_MTD
> 
> -- 1.7.9.5
> 
> XS Embedded GmbH
> Peterzeller Strasse 8
> D-78048 Villingen - Schwenningen
> 
> Telefon +49 (7721) 4060 - 428
> Fax     +49 (7721) 4060 - 499
> 
> www.xse.de
> Philipp.Rosenberger-wIELUdCntIg@public.gmane.org
> 
> :::::::::: based.on.visions ::::::::::
> 
> 
> XS Embedded GmbH
> Geschäftsführung: Michael Maier, Rainer Oder
> 
> Handelsregister: Amtsgericht Freiburg i.Br., HRB 705237
> Sitz der Gesellschaft: Peterzeller Strasse 8, 78048 Villingen-Schwenningen
> USt-Id Nummer: DE268786819
> 
> Confidentiality Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.

This confidentiality notice is incongruous with sending patches to a
public mailing list, for inclusion in an open source project. This
message (combined with a lack of a Signed-off-by) means we cannot take
your patch. Please remove this footer and resubmit, with a CC to
linux-mtd-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org and devicetree-u79uwXL29TaiAVqoAR/hOA@public.gmane.org

Thanks,
Brian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

       reply	other threads:[~2013-11-29  8:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <52972EEE.8070704@xse.de>
     [not found] ` <52972EEE.8070704-wIELUdCntIg@public.gmane.org>
2013-11-29  8:11   ` Brian Norris [this message]
2013-11-29  9:22     ` [PATCH] of_mtd: Fix header file include guard Rosenberger, Philipp
     [not found]       ` <52985D12.6060901-wIELUdCntIg@public.gmane.org>
2013-12-02 19:55         ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131129081113.GA20013@norris.computersforpeace.net \
    --to=computersforpeace-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=Philipp.Rosenberger-wIELUdCntIg@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).