devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Rutland <mark.rutland@arm.com>
To: Alex Ling <kasimling@gmail.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"kgene.kim@samsung.com" <kgene.kim@samsung.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	Pawel Moll <Pawel.Moll@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	"ben-linux@fluff.org" <ben-linux@fluff.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node
Date: Mon, 2 Dec 2013 09:52:53 +0000	[thread overview]
Message-ID: <20131202095253.GC12952@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <1385892707-25063-1-git-send-email-kasimling@gmail.com>

On Sun, Dec 01, 2013 at 10:11:47AM +0000, Alex Ling wrote:
> This patch adds "biu" and "ciu" clock names for exynos4412 dwmmc
> node. Without this patch, dwmmc host driver will skip enabling the
> two clocks and it will break dwmmc host function on exynos4412.
> Tested on FriendlyARM TINY4412 board.

The patch description is a little off; this patch adds the clocks as
well as the clock-names.

The patch itself looks fine to me.

Mark.

> 
> Signed-off-by: Alex Ling <kasimling@gmail.com>
> ---
>  arch/arm/boot/dts/exynos4412.dtsi |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
> index e743e67..67bef99 100644
> --- a/arch/arm/boot/dts/exynos4412.dtsi
> +++ b/arch/arm/boot/dts/exynos4412.dtsi
> @@ -67,5 +67,7 @@
>  		interrupts = <0 77 0>;
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> +		clocks = <&clock 301>, <&clock 149>;
> +		clock-names = "biu", "ciu";
>  	};
>  };
> -- 
> 1.7.9.5
> 
> 

  reply	other threads:[~2013-12-02  9:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-01 10:11 [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node Alex Ling
2013-12-02  9:52 ` Mark Rutland [this message]
2013-12-02 14:01   ` Alex Ling
  -- strict thread matches above, loose matches on Subject: below --
2013-11-26  6:00 linux 3.13-rc1 make dw_mmc-exynos more worse randy
2013-12-01 12:30 ` [PATCH 1/1] ARM: dts: Add missing clock names for exynos4412 dwmmc node randy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131202095253.GC12952@e106331-lin.cambridge.arm.com \
    --to=mark.rutland@arm.com \
    --cc=Pawel.Moll@arm.com \
    --cc=ben-linux@fluff.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kasimling@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=rob.herring@calxeda.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).