Re: [PATCH v1 1/1] dts: bindings: add mpc5121 clocks binding document

[Gerhard Sittig <gsi-ynQEQJNshbs@public.gmane.org>]

On Mon, Dec 02, 2013 at 15:20 +0100, Gerhard Sittig wrote:
> 
> add a clock bindings documentation file for Freescale MPC5121
> 
> this binding implements and uses existing common clock bindings,
> it does not introduce a new binding semantics but discusses the
> specific use on Freescale MPC5121 and provides examples
> 
> [ ... ]
> 
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/mpc5121-clock.txt
> @@ -0,0 +1,95 @@
> +Device Tree Clock bindings for Freescale MPC5121
> +
> [ ... ]
> +
> +Required properties:
> +- compatible:	shall contain "fsl,mpc5121-clock"
> +- reg:		shall specify the start address and length of the
> +		clock module's set of control registers
> +- #clock-cells:	shall be 1; defines the number of integer cells
> +		required for a clock specifier which references
> +		this clock provider

In hindsight the wording is not good (especially 'reg'), will see
how I can improve this.  And the layout may improve some more.

> +
> +Optional properties:
> +- clocks:	list of phandle and clock specifier pairs for the
> +		node's input clocks, following the common clock
> +		consumers binding; should be empty, or one XTAL/OSC
> +		clock reference
> +- clock-names:	list of clock input name strings sorted in the same
> +		order as the 'clocks' property

Mark, I very much like your suggestion to state that 'clocks'
should match 'clock-names' (and not vice versa, found in another
thread, after having sent this patch).

And noticed that 'clock-names' still does not say that the
XTAL/OSC should go by the name "osc".  And should not say that at
most one clock is accepted or how their order is.


So I will wait for more feedback, but can tell already that v1
needs an update before becoming acceptable.  Thank you for your
patience. :)


virtually yours
Gerhard Sittig
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office-ynQEQJNshbs@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html