From: Tony Lindgren <tony@atomide.com>
To: Florian Vaussard <florian.vaussard@epfl.ch>
Cc: Benoit Cousson <bcousson@baylibre.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: Fix the name of supplies for smsc911x shared by OMAP
Date: Mon, 2 Dec 2013 11:29:26 -0800 [thread overview]
Message-ID: <20131202192925.GK26766@atomide.com> (raw)
In-Reply-To: <1385988782-21731-1-git-send-email-florian.vaussard@epfl.ch>
* Florian Vaussard <florian.vaussard@epfl.ch> [131202 04:54]:
> drivers/net/ethernet/smsc/smsc911x.c is expecting supplies named
> "vdd33a" and "vddvario". Currently the shared DTS file provides
> "vmmc" and "vmmc_aux", and the supply lookup will fail:
>
> smsc911x 2c000000.ethernet: Looking up vdd33a-supply from device tree
> smsc911x 2c000000.ethernet: Looking up vdd33a-supply property in node /ocp/gpmc@6e000000/ethernet@gpmc failed
> smsc911x 2c000000.ethernet: Looking up vddvario-supply from device tree
> smsc911x 2c000000.ethernet: Looking up vddvario-supply property in node /ocp/gpmc@6e000000/ethernet@gpmc failed
>
> Fix it!
>
> Tested on OMAP3 Overo platform.
OK, looks like we've had it wrong from the start as I just moved it from
the omap3-igep0020.dts file :) Applying into omap-for-v3.14/fixes-take4
Regards,
Tony
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
> ---
> arch/arm/boot/dts/omap-gpmc-smsc911x.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/omap-gpmc-smsc911x.dtsi b/arch/arm/boot/dts/omap-gpmc-smsc911x.dtsi
> index 9c18adf..f577b7d 100644
> --- a/arch/arm/boot/dts/omap-gpmc-smsc911x.dtsi
> +++ b/arch/arm/boot/dts/omap-gpmc-smsc911x.dtsi
> @@ -44,8 +44,8 @@
> gpmc,wr-access-ns = <186>;
> gpmc,cycle2cycle-samecsen;
> gpmc,cycle2cycle-diffcsen;
> - vmmc-supply = <&vddvario>;
> - vmmc_aux-supply = <&vdd33a>;
> + vddvario-supply = <&vddvario>;
> + vdd33a-supply = <&vdd33a>;
> reg-io-width = <4>;
> smsc,save-mac-address;
> };
> --
> 1.8.1.2
>
prev parent reply other threads:[~2013-12-02 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-02 12:53 [PATCH] ARM: dts: Fix the name of supplies for smsc911x shared by OMAP Florian Vaussard
2013-12-02 19:29 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131202192925.GK26766@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@epfl.ch \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).