From: Lee Jones <lee.jones@linaro.org>
To: Keerthy <j-keerthy@ti.com>
Cc: rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, rob@landley.net,
sameo@linux.intel.com, grant.likely@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/4] mfd: DT bindings for TPS65218 PMIC
Date: Tue, 3 Dec 2013 09:36:37 +0000 [thread overview]
Message-ID: <20131203093637.GE11828@lee--X1> (raw)
In-Reply-To: <1386053006-6480-2-git-send-email-j-keerthy@ti.com>
> Add DT bindings for TPS65218 PMIC.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> Documentation/devicetree/bindings/mfd/tps65218.txt | 27 ++++++++++++++++++++
> .../devicetree/bindings/regulator/tps65218.txt | 22 ++++++++++++++++
> 2 files changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/tps65218.txt
> create mode 100644 Documentation/devicetree/bindings/regulator/tps65218.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/tps65218.txt b/Documentation/devicetree/bindings/mfd/tps65218.txt
> new file mode 100644
> index 0000000..87cb7a8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/tps65218.txt
> @@ -0,0 +1,27 @@
> +The TPS65218 Integrated Power Management Chips.
> +These chips are connected to an i2c bus.
I2C
> +Required properties:
> +- compatible : Must be "ti,tps65218";
> +- interrupts : This i2c device has an IRQ line connected to the main SoC
I2C
> +- interrupt-controller : Since the tps65218 support several interrupts
support(s) (hosts?)
> + internally, it is considered as an interrupt controller cascaded to the SoC.
> +- #interrupt-cells = <2>;
> +- interrupt-parent : The parent interrupt controller.
Phandle to ...
> +Optional node:
node(s):
> +- Child nodes contain in the tps65218.
> + It supports a number of features.
Please re-phase the above two sentences to something decipherable.
> + The children nodes will thus depend of the capability of the variant.
Please, go on ...
> +Example:
> +/*
> + * Integrated Power Management Chip
> + */
> +tps@24 {
> + compatible = "ti,tps65218";
> + reg = <0x24>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupt-parent = <&gic>;
> +};
Perhaps it would be better to centralise the documentation inclusive
of the regulator contingent. Or at least provide a _full_ example in
each document.
> diff --git a/Documentation/devicetree/bindings/regulator/tps65218.txt b/Documentation/devicetree/bindings/regulator/tps65218.txt
> new file mode 100644
> index 0000000..1ccf170
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/tps65218.txt
> @@ -0,0 +1,22 @@
> +TPS65218 family of regulators
> +
> +Required properties:
> +For tps65218 regulators/LDOs
> +- compatible:
> + - "ti,tps65218-dcdc1" for DCDC1
> + - "ti,tps65218-dcdc2" for DCDC2
> + - "ti,tps65218-dcdc3" for DCDC3
> + - "ti,tps65218-dcdc4" for DCDC4
> + - "ti,tps65218-dcdc5" for DCDC5
> + - "ti,tps65218-dcdc6" for DCDC6
> + - "ti,tps65218-ldo1" for LDO1 LDO
Why aren't you using 'regulator-compatible'?
> +Optional properties:
> +- Any optional property defined in bindings/regulator/regulator.txt
> +
> +Example:
> + xyz: regulator@0 {
Genuine question: Is the @0 meaningful?
> + compatible = "ti,tps65218-dcdc1";
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <3000000>;
> + };
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-12-03 9:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 6:43 [PATCH 0/4] mfd: TPS65218: Add support for TPS65218 PMIC Keerthy
2013-12-03 6:43 ` [PATCH 1/4] mfd: DT bindings " Keerthy
2013-12-03 9:36 ` Lee Jones [this message]
2013-12-03 10:52 ` Keerthy
2013-12-03 11:04 ` Lee Jones
2013-12-03 6:43 ` [PATCH 2/4] MFD: TPS65218: Add driver for the " Keerthy
2013-12-03 9:24 ` Lee Jones
2013-12-03 10:06 ` Keerthy
2013-12-03 11:21 ` Lee Jones
2013-12-03 13:28 ` Mark Brown
2013-12-03 15:19 ` Mark Brown
2013-12-03 6:43 ` [PATCH 3/4] Regulators: TPS65218: Add Regulator driver for " Keerthy
2013-12-03 15:16 ` Mark Brown
[not found] ` <20131203151654.GB27568-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-04 5:59 ` Keerthy
2013-12-04 7:39 ` Manish Badarkhe
2013-12-03 6:43 ` [PATCH 4/4] ARM: dts: AM437x: Add TPS65218 device tree nodes Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203093637.GE11828@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).