From: Lee Jones <lee.jones@linaro.org>
To: Keerthy <a0393675@ti.com>
Cc: Keerthy <j-keerthy@ti.com>,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, rob@landley.net,
sameo@linux.intel.com, grant.likely@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC
Date: Tue, 3 Dec 2013 11:21:07 +0000 [thread overview]
Message-ID: <20131203112107.GP11828@lee--X1> (raw)
In-Reply-To: <529DAD2B.4040909@ti.com>
> >>+ ret = of_platform_populate(client->dev.of_node, NULL, NULL,
> >>+ &client->dev);
> >What are you trying to do here?
> >
> >Register each regulator as a platform device?
>
> Yeah. The probe will be called for every regulator separately.
So there are two schools of thought on this. One is that if you want
to do it that way you should use the MFD framework to do this for you.
There is no need to recreate functionality that already exists. The
other is that you shouldn't be doing this at all with regulators. Mark
likes the idea of having a single regulator controller node which
contains all of these individual regulator sub-nodes and you initiate
a single call to for_each_child_of_node() within the driver in order
to register them all.
<snip>
> >This has a different structure to of_tps65218_match_table, please
> >ensure they're the same. I prefer spaces after '{' and before '}'.
>
> Ok. I will add a space after '{' and before '}'. Sorry I did not
> follow tps65218_id_table being different than of_tps65218_match_table.
>
> One is of the type of_device_id and the other i2c_device_id.
Shouldn't matter, it's just a formatting thing.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-12-03 11:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 6:43 [PATCH 0/4] mfd: TPS65218: Add support for TPS65218 PMIC Keerthy
2013-12-03 6:43 ` [PATCH 1/4] mfd: DT bindings " Keerthy
2013-12-03 9:36 ` Lee Jones
2013-12-03 10:52 ` Keerthy
2013-12-03 11:04 ` Lee Jones
2013-12-03 6:43 ` [PATCH 2/4] MFD: TPS65218: Add driver for the " Keerthy
2013-12-03 9:24 ` Lee Jones
2013-12-03 10:06 ` Keerthy
2013-12-03 11:21 ` Lee Jones [this message]
2013-12-03 13:28 ` Mark Brown
2013-12-03 15:19 ` Mark Brown
2013-12-03 6:43 ` [PATCH 3/4] Regulators: TPS65218: Add Regulator driver for " Keerthy
2013-12-03 15:16 ` Mark Brown
[not found] ` <20131203151654.GB27568-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2013-12-04 5:59 ` Keerthy
2013-12-04 7:39 ` Manish Badarkhe
2013-12-03 6:43 ` [PATCH 4/4] ARM: dts: AM437x: Add TPS65218 device tree nodes Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131203112107.GP11828@lee--X1 \
--to=lee.jones@linaro.org \
--cc=a0393675@ti.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=j-keerthy@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).