From: Thierry Reding <thierry.reding@gmail.com>
To: Milo Kim <milo.kim@ti.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pwm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v4 3/4] pwm: add LP3943 PWM driver
Date: Wed, 4 Dec 2013 11:31:27 +0100 [thread overview]
Message-ID: <20131204103125.GA26589@ulmo.nvidia.com> (raw)
In-Reply-To: <1380083078-6212-1-git-send-email-milo.kim@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1387 bytes --]
On Wed, Sep 25, 2013 at 01:24:38PM +0900, Milo Kim wrote:
> This is the other of the LP3943 MFD driver.
> LP3943 can be used as a PWM generator, up to 2 channels.
>
> * Two PWM generators supported
>
> * Supported PWM operations
> request, free, config, enable and disable
>
> * Pin assignment
> A driver data, 'pin_used' is checked when a PWM is requested.
> If the output pin is already assigned, then returns as failure.
> If the pin is available, 'pin_used' is set.
> When the PWM is not used anymore, then it is cleared.
> It is defined as unsigned long type for atomic bit operation APIs,
> but only LSB 16bits are used because LP3943 has 16 outputs.
>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Signed-off-by: Milo Kim <milo.kim@ti.com>
> ---
> * Patch v4
> No update, same as v3.
>
> * Patch v3
> Manual polarity not supported any more.
> Add encapsulation functions for accessing internal data structure.
> Use pwm_set_chip_data() and pwm_get_chip_data().
> And other code fixes based on Thierry's feedback.
>
> drivers/pwm/Kconfig | 10 ++
> drivers/pwm/Makefile | 1 +
> drivers/pwm/pwm-lp3943.c | 314 ++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 325 insertions(+)
> create mode 100644 drivers/pwm/pwm-lp3943.c
Acked-by: Thierry Reding <thierry.reding@gmail.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-12-04 10:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 4:24 [PATCH v4 3/4] pwm: add LP3943 PWM driver Milo Kim
2013-12-04 10:31 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131204103125.GA26589@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).