From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document Date: Wed, 4 Dec 2013 13:41:56 +0000 Message-ID: <20131204134156.GA25422@lee--X1> References: <1386153615-25456-1-git-send-email-k.kozlowski@samsung.com> <1386153615-25456-4-git-send-email-k.kozlowski@samsung.com> <20131204112039.GC907@lee--X1> <1386164272.6195.3.camel@AMDC1943> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1386164272.6195.3.camel@AMDC1943> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Rob Landley , Anton Vorontsov , David Woodhouse , Liam Girdwood , Mark Brown , Kyungmin Park , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Bartlomiej Zolnierkiewicz , Marek Szyprowski , Chanwoo Choi List-Id: devicetree@vger.kernel.org > > > +MAXIM MAX14577 multi-function device > >=20 > > Why is Maxim capitalised in such a way? > >=20 > > If you're going to use the term Multi-Function Device, please > > capitalise it. > >=20 > > > +MAX14577 is a Multi-function device with Micro-USB Interface Cir= cuit, Li+ > >=20 > > Same here. >=20 > I'll fix this. The MAXIM capitalization came from other drivers. No need to repeat mistakes. I believe it should be Maxim. > > > +Example: > > > + max14577@25 { > > > + compatible =3D "maxim,max14577"; > > > + reg =3D <0x25>; > > > + interrupt-parent =3D <&gpx1>; > > > + interrupts =3D <5 0>; > >=20 > > I'm gussing this is IRQ5 and the 0 is flags? If so, please use > > #defines for the flags. >=20 > This is a standard interrupt binding. The max14577 MFD core driver > ignores the interrupt flags and always uses IRQF_TRIGGER_FALLING. I c= an > fix this with new patch for drivers/mfd/max14577.c but still I don't = see > what should be added in documentation. s/0/IRQ_TYPE_NONE --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html