* [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
@ 2013-12-04 9:20 dt.tangr
2013-12-04 9:20 ` [PATCH 2/2] arm: nspire: modify device tree to use the nspire-usb driver dt.tangr
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: dt.tangr @ 2013-12-04 9:20 UTC (permalink / raw)
To: linux-usb; +Cc: Daniel Tang, linux-kernel, devicetree, linux-doc
From: Daniel Tang <dt.tangr@gmail.com>
The SoC name was mistakenly used instead of the vendor name in the
device tree binding for nspire-usb.
This patch fixes this before the driver becomes widely adopted.
Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
---
Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt | 4 ++--
drivers/usb/chipidea/ci_hdrc_nspire.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
index 5ba8e90..ef1fcbf 100644
--- a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
+++ b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
@@ -1,7 +1,7 @@
* TI-Nspire USB OTG Controller
Required properties:
-- compatible: Should be "zevio,nspire-usb"
+- compatible: Should be "lsi,nspire-usb"
- reg: Should contain registers location and length
- interrupts: Should contain controller interrupt
@@ -11,7 +11,7 @@ Recommended properies:
Examples:
usb0: usb@B0000000 {
reg = <0xB0000000 0x1000>;
- compatible = "zevio,nspire-usb";
+ compatible = "lsi,nspire-usb";
interrupts = <8>;
vbus-supply = <&vbus_reg>;
};
diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c
index 517ce41..c5c2dde 100644
--- a/drivers/usb/chipidea/ci_hdrc_nspire.c
+++ b/drivers/usb/chipidea/ci_hdrc_nspire.c
@@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev)
}
static const struct of_device_id ci_hdrc_nspire_dt_ids[] = {
- { .compatible = "zevio,nspire-usb", },
+ { .compatible = "lsi,nspire-usb", },
{ /* sentinel */ }
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] arm: nspire: modify device tree to use the nspire-usb driver
2013-12-04 9:20 [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio' dt.tangr
@ 2013-12-04 9:20 ` dt.tangr
2013-12-04 12:18 ` [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio' Mark Rutland
2013-12-04 13:44 ` Peter Chen
2 siblings, 0 replies; 9+ messages in thread
From: dt.tangr @ 2013-12-04 9:20 UTC (permalink / raw)
To: linux-usb
Cc: Daniel Tang, linux-kernel, devicetree, linux-doc,
linux-arm-kernel, linux
From: Daniel Tang <dt.tangr@gmail.com>
This patch adds the needed compatible key to the device tree for TI-Nspires.
Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
---
arch/arm/boot/dts/nspire.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/nspire.dtsi b/arch/arm/boot/dts/nspire.dtsi
index a22ffe6..baf7153 100644
--- a/arch/arm/boot/dts/nspire.dtsi
+++ b/arch/arm/boot/dts/nspire.dtsi
@@ -65,6 +65,7 @@
};
usb0: usb@B0000000 {
+ compatible = "lsi,nspire-usb";
reg = <0xB0000000 0x1000>;
interrupts = <8>;
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
2013-12-04 9:20 [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio' dt.tangr
2013-12-04 9:20 ` [PATCH 2/2] arm: nspire: modify device tree to use the nspire-usb driver dt.tangr
@ 2013-12-04 12:18 ` Mark Rutland
2013-12-05 5:45 ` Daniel Tang
2013-12-04 13:44 ` Peter Chen
2 siblings, 1 reply; 9+ messages in thread
From: Mark Rutland @ 2013-12-04 12:18 UTC (permalink / raw)
To: dt.tangr@gmail.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
On Wed, Dec 04, 2013 at 09:20:07AM +0000, dt.tangr@gmail.com wrote:
> From: Daniel Tang <dt.tangr@gmail.com>
>
> The SoC name was mistakenly used instead of the vendor name in the
> device tree binding for nspire-usb.
>
> This patch fixes this before the driver becomes widely adopted.
How widely adopted is it so far?
I can't see the binding in mainline yet.
>
> Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt | 4 ++--
> drivers/usb/chipidea/ci_hdrc_nspire.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> index 5ba8e90..ef1fcbf 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> @@ -1,7 +1,7 @@
> * TI-Nspire USB OTG Controller
>
> Required properties:
> -- compatible: Should be "zevio,nspire-usb"
> +- compatible: Should be "lsi,nspire-usb"
Surely this should be lsi,zevio-usb, matching the lsi,zevio-timer
binding?
Thanks,
Mark.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
2013-12-04 9:20 [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio' dt.tangr
2013-12-04 9:20 ` [PATCH 2/2] arm: nspire: modify device tree to use the nspire-usb driver dt.tangr
2013-12-04 12:18 ` [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio' Mark Rutland
@ 2013-12-04 13:44 ` Peter Chen
2013-12-05 5:44 ` Daniel Tang
2 siblings, 1 reply; 9+ messages in thread
From: Peter Chen @ 2013-12-04 13:44 UTC (permalink / raw)
To: dt.tangr; +Cc: linux-usb, linux-kernel, devicetree, linux-doc
On Wed, Dec 04, 2013 at 08:20:07PM +1100, dt.tangr@gmail.com wrote:
> From: Daniel Tang <dt.tangr@gmail.com>
>
> The SoC name was mistakenly used instead of the vendor name in the
> device tree binding for nspire-usb.
>
> This patch fixes this before the driver becomes widely adopted.
>
> Signed-off-by: Daniel Tang <dt.tangr@gmail.com>
> ---
> Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt | 4 ++--
> drivers/usb/chipidea/ci_hdrc_nspire.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> index 5ba8e90..ef1fcbf 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> @@ -1,7 +1,7 @@
> * TI-Nspire USB OTG Controller
>
> Required properties:
> -- compatible: Should be "zevio,nspire-usb"
> +- compatible: Should be "lsi,nspire-usb"
lsi is vendor name, what are zevio and nspire?
Usually, the compatible string should be "vendor_name,soc_name-module_name"
> - reg: Should contain registers location and length
> - interrupts: Should contain controller interrupt
>
> @@ -11,7 +11,7 @@ Recommended properies:
> Examples:
> usb0: usb@B0000000 {
> reg = <0xB0000000 0x1000>;
> - compatible = "zevio,nspire-usb";
> + compatible = "lsi,nspire-usb";
> interrupts = <8>;
> vbus-supply = <&vbus_reg>;
> };
> diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c
> index 517ce41..c5c2dde 100644
> --- a/drivers/usb/chipidea/ci_hdrc_nspire.c
> +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c
> @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev)
> }
>
> static const struct of_device_id ci_hdrc_nspire_dt_ids[] = {
> - { .compatible = "zevio,nspire-usb", },
> + { .compatible = "lsi,nspire-usb", },
> { /* sentinel */ }
> };
>
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
2013-12-04 13:44 ` Peter Chen
@ 2013-12-05 5:44 ` Daniel Tang
2013-12-05 8:49 ` Peter Chen
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Tang @ 2013-12-05 5:44 UTC (permalink / raw)
To: Peter Chen; +Cc: linux-usb, linux-kernel, devicetree, linux-doc
Hi,
On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@freescale.com> wrote:
>
> lsi is vendor name, what are zevio and nspire?
> Usually, the compatible string should be "vendor_name,soc_name-module_name"
>
Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.
If it's usually "vendor_name,soc_name-module_name", I'll fix up this patch with zevio instead of nspire (and it'll be more consistent with the other drivers).
>> - reg: Should contain registers location and length
>> - interrupts: Should contain controller interrupt
>>
>> @@ -11,7 +11,7 @@ Recommended properies:
>> Examples:
>> usb0: usb@B0000000 {
>> reg = <0xB0000000 0x1000>;
>> - compatible = "zevio,nspire-usb";
>> + compatible = "lsi,nspire-usb";
>> interrupts = <8>;
>> vbus-supply = <&vbus_reg>;
>> };
>> diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c
>> index 517ce41..c5c2dde 100644
>> --- a/drivers/usb/chipidea/ci_hdrc_nspire.c
>> +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c
>> @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev)
>> }
>>
>> static const struct of_device_id ci_hdrc_nspire_dt_ids[] = {
>> - { .compatible = "zevio,nspire-usb", },
>> + { .compatible = "lsi,nspire-usb", },
>> { /* sentinel */ }
>> };
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
>
> Best Regards,
> Peter Chen
>
Cheers,
Daniel Tang
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
2013-12-04 12:18 ` [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio' Mark Rutland
@ 2013-12-05 5:45 ` Daniel Tang
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Tang @ 2013-12-05 5:45 UTC (permalink / raw)
To: Mark Rutland
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Hi,
On 04/12/2013, at 11:18 PM, Mark Rutland <mark.rutland@arm.com> wrote:
>>
>>
>> Required properties:
>> -- compatible: Should be "zevio,nspire-usb"
>> +- compatible: Should be "lsi,nspire-usb"
>
> Surely this should be lsi,zevio-usb, matching the lsi,zevio-timer
> binding?
You're right. I'll fix up the patch and send it back in.
>
> Thanks,
> Mark.
Cheers,
Daniel Tang
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
2013-12-05 5:44 ` Daniel Tang
@ 2013-12-05 8:49 ` Peter Chen
[not found] ` <20131205084909.GA25943-KgLukfWpBlCctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
0 siblings, 1 reply; 9+ messages in thread
From: Peter Chen @ 2013-12-05 8:49 UTC (permalink / raw)
To: Daniel Tang; +Cc: linux-usb, linux-kernel, devicetree, linux-doc
On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote:
> Hi,
>
> On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@freescale.com> wrote:
>
> >
> > lsi is vendor name, what are zevio and nspire?
> > Usually, the compatible string should be "vendor_name,soc_name-module_name"
> >
>
> Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.
>
Please wrap the line to 80 characters.
The driver is written for the TI-Nspire, and you port this driver for
SoC Zevio platform? Since you use chipidea ip, we don't care the usb
module name at your platform, we only care the soc name which you are
running, it can detect the SoC platform at runtime.
At your dts patch, it still uses nspire-usb.
http://marc.info/?l=linux-usb&m=138614886720024&w=2
Peter
> If it's usually "vendor_name,soc_name-module_name", I'll fix up this patch with zevio instead of nspire (and it'll be more consistent with the other drivers).
>
> >> - reg: Should contain registers location and length
> >> - interrupts: Should contain controller interrupt
> >>
> >> @@ -11,7 +11,7 @@ Recommended properies:
> >> Examples:
> >> usb0: usb@B0000000 {
> >> reg = <0xB0000000 0x1000>;
> >> - compatible = "zevio,nspire-usb";
> >> + compatible = "lsi,nspire-usb";
> >> interrupts = <8>;
> >> vbus-supply = <&vbus_reg>;
> >> };
> >> diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c
> >> index 517ce41..c5c2dde 100644
> >> --- a/drivers/usb/chipidea/ci_hdrc_nspire.c
> >> +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c
> >> @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev)
> >> }
> >>
> >> static const struct of_device_id ci_hdrc_nspire_dt_ids[] = {
> >> - { .compatible = "zevio,nspire-usb", },
> >> + { .compatible = "lsi,nspire-usb", },
> >> { /* sentinel */ }
> >> };
> >>
> >> --
> >> 1.7.10.4
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >>
> >
> > --
> >
> > Best Regards,
> > Peter Chen
> >
>
> Cheers,
> Daniel Tang
--
Best Regards,
Peter Chen
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
[not found] ` <20131205084909.GA25943-KgLukfWpBlCctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
@ 2013-12-05 10:10 ` Daniel Tang
2013-12-06 2:27 ` Peter Chen
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Tang @ 2013-12-05 10:10 UTC (permalink / raw)
To: Peter Chen
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-doc-u79uwXL29TY76Z2rM5mHXA
Hi,
On 05/12/2013, at 7:49 PM, Peter Chen <Peter.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> wrote:
> On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote:
>> Hi,
>>
>> On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org> wrote:
>>
>>>
>>> lsi is vendor name, what are zevio and nspire?
>>> Usually, the compatible string should be "vendor_name,soc_name-module_name"
>>>
>>
>> Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.
>>
>
> Please wrap the line to 80 characters.
>
> The driver is written for the TI-Nspire, and you port this driver for
> SoC Zevio platform?
The TI-Nspire runs on the Zevio SoC.
> Since you use chipidea ip, we don't care the usb
> module name at your platform, we only care the soc name which you are
> running, it can detect the SoC platform at runtime.
>
Yep, that's why the latest patch I sent in renames the device tree
binding to "lsi,zevio-usb" since zevio is the name of the SoC that the
TI-Nspire uses.
> At your dts patch, it still uses nspire-usb.
> http://marc.info/?l=linux-usb&m=138614886720024&w=2
I'll send a new one in right now.
>
> Peter
Cheers,
Daniel Tang--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
2013-12-05 10:10 ` Daniel Tang
@ 2013-12-06 2:27 ` Peter Chen
0 siblings, 0 replies; 9+ messages in thread
From: Peter Chen @ 2013-12-06 2:27 UTC (permalink / raw)
To: Daniel Tang
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
>
> Hi,
>
> On 05/12/2013, at 7:49 PM, Peter Chen <Peter.Chen@freescale.com> wrote:
>
> > On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote:
> >> Hi,
> >>
> >> On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@freescale.com>
> wrote:
> >>
> >>>
> >>> lsi is vendor name, what are zevio and nspire?
> >>> Usually, the compatible string should be "vendor_name,soc_name-
> module_name"
> >>>
> >>
> >> Because this port uses documentation from reverse engineering, it's
> difficult to work out what is SoC specific and what is device specific.
> The SoC is Zevio but the driver is written for the TI-Nspire.
> >>
> >
> > Please wrap the line to 80 characters.
> >
> > The driver is written for the TI-Nspire, and you port this driver for
> > SoC Zevio platform?
>
> The TI-Nspire runs on the Zevio SoC.
>
> > Since you use chipidea ip, we don't care the usb
> > module name at your platform, we only care the soc name which you are
> > running, it can detect the SoC platform at runtime.
> >
>
> Yep, that's why the latest patch I sent in renames the device tree
> binding to "lsi,zevio-usb" since zevio is the name of the SoC that the
> TI-Nspire uses.
>
> > At your dts patch, it still uses nspire-usb.
> > http://marc.info/?l=linux-usb&m=138614886720024&w=2
>
> I'll send a new one in right now.
OK, in order to avoid changing name again, I will queue your patch at my pending
chipidea tree until your dts has applied by arch or dts maintainer, notify me
when they are ready.
Peter
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-12-06 2:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-04 9:20 [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio' dt.tangr
2013-12-04 9:20 ` [PATCH 2/2] arm: nspire: modify device tree to use the nspire-usb driver dt.tangr
2013-12-04 12:18 ` [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio' Mark Rutland
2013-12-05 5:45 ` Daniel Tang
2013-12-04 13:44 ` Peter Chen
2013-12-05 5:44 ` Daniel Tang
2013-12-05 8:49 ` Peter Chen
[not found] ` <20131205084909.GA25943-KgLukfWpBlCctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2013-12-05 10:10 ` Daniel Tang
2013-12-06 2:27 ` Peter Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).