From: Thierry Reding <thierry.reding@gmail.com>
To: Denis Carikli <denis@eukrea.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Eric Bénard" <eric@eukrea.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Jingoo Han" <jg1.han@samsung.com>,
"Rob Herring" <rob.herring@calxeda.com>,
"Richard Purdie" <rpurdie@rpsys.net>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Jean-Christophe Plagniol-Villard" <plagnioj@jcrosoft.com>,
linux-arm-kernel@lists.infradead.org,
"Lothar Waßmann" <LW@KARO-electronics.de>
Subject: Re: [PATCHv7][ 2/2] video: backlight: gpio-backlight: Add DT support.
Date: Fri, 6 Dec 2013 14:00:15 +0100 [thread overview]
Message-ID: <20131206130014.GB30625@ulmo.nvidia.com> (raw)
In-Reply-To: <1386266109-16071-2-git-send-email-denis@eukrea.com>
[-- Attachment #1.1: Type: text/plain, Size: 948 bytes --]
On Thu, Dec 05, 2013 at 06:55:09PM +0100, Denis Carikli wrote:
[...]
> +Optional properties:
> + - default-state: The initial state of the backlight.
> + Valid values are "on", "off", and "keep".
> + The "keep" setting will keep the backlight at whatever its current
> + state is, without producing a glitch. The default is keep if this
> + property is not present.
I'm not sure if "on", "off" and "keep" are a good choice for this
binding. Having strings for these tristate values seems suboptimal.
Other bindings have chosen a representation that, transposed to this
use-case, would read something like this:
- default-state: The initial state of the backlight. Valid
values:
- 0: off
- 1: on
If the "default-state" property is not present, the default
will be to keep the current backlight state.
Which is in fact the exact behaviour that your binding describes, but
it's much more intuitive in my opinion.
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2013-12-06 13:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 17:55 [PATCHv7][ 1/2] backlight: gpio_backlight: Use a default state enum Denis Carikli
[not found] ` <1386266109-16071-1-git-send-email-denis-fO0SIAKYzcbQT0dZR+AlfA@public.gmane.org>
2013-12-05 17:55 ` [PATCHv7][ 2/2] video: backlight: gpio-backlight: Add DT support Denis Carikli
2013-12-06 13:00 ` Thierry Reding [this message]
[not found] ` <20131206130014.GB30625-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-06 13:08 ` Alexander Shiyan
[not found] ` <1386335318.12471946-q5D3CJL46AJsdVUOrk1QfQ@public.gmane.org>
2013-12-06 14:12 ` Thierry Reding
[not found] ` <20131206141236.GA32313-AwZRO8vwLAwmlAP/+Wk3EA@public.gmane.org>
2013-12-06 14:48 ` Alexander Shiyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206130014.GB30625@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=LW@KARO-electronics.de \
--cc=denis@eukrea.com \
--cc=devicetree@vger.kernel.org \
--cc=eric@eukrea.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jg1.han@samsung.com \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=rpurdie@rpsys.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).