From: Nicolin Chen <b42378@freescale.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, alsa-devel@alsa-project.org, tiwai@suse.de,
perex@perex.cz, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
rob@landley.net, ijc+devicetree@hellion.org.uk,
swarren@wwwdotorg.org, mark.rutland@arm.com, pawel.moll@arm.com,
rob.herring@calxeda.com
Subject: Re: [PATCH 3/3] ASoC: fsl: imx-wm8962: Add headphone and microphone jack plugin/out detection
Date: Fri, 6 Dec 2013 22:52:40 +0800 [thread overview]
Message-ID: <20131206145239.GA30024@MrMyself> (raw)
In-Reply-To: <20131206150319.GJ29268@sirena.org.uk>
On Fri, Dec 06, 2013 at 03:03:19PM +0000, Mark Brown wrote:
> On Fri, Dec 06, 2013 at 10:38:17PM +0800, Nicolin Chen wrote:
> > On Fri, Dec 06, 2013 at 02:42:56PM +0000, Mark Brown wrote:
>
> > > What's this uevent trying to do and why is it open coded in the driver?
>
> > That's a requirement from Android team of Freescale. By checking this
> > event they can determine whether current output is speaker or headphone
> > so as to place an icon on the notification area.
>
> > Sir, if you think this patch is not common enough or non-community style,
> > I can try to cut it down to an common one or entirely drop it.
>
> This isn't mainline stuff, this is the Android standard switch class.
> Someone should really contribute something to Android which backs it
> onto the back of ALSA jacks. The mainline equivalent is extcon which
> does have switch class emulation but it's a bit broken in its generation
> of uevents and is also not yet integrated into the ALSA jack stuff.
>
> The thing to do is ideally integrate extcon with the ALSA jack code and
> update the Android headset observer to work with extcon (or write a
> separate extcon based observer).
Thank you for the detailed explain. It looks more complicated to me with
current code base. I think I should just extract the mainline-style part
so it'll make things easy if there's gonna be some plausible integrations
afterward.
Thank you indeed,
Nicolin Chen
prev parent reply other threads:[~2013-12-06 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1386322845.git.b42378@freescale.com>
[not found] ` <cover.1386322845.git.b42378-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-06 9:48 ` [PATCH 3/3] ASoC: fsl: imx-wm8962: Add headphone and microphone jack plugin/out detection Nicolin Chen
2013-12-06 14:42 ` Mark Brown
2013-12-06 14:38 ` Nicolin Chen
2013-12-06 15:03 ` Mark Brown
2013-12-06 14:52 ` Nicolin Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131206145239.GA30024@MrMyself \
--to=b42378@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).