From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v4 3/6] ARM: at91/dt: define sama5d3 clocks Date: Mon, 9 Dec 2013 03:09:23 +0100 Message-ID: <201312090309.23723.arnd@arndb.de> References: <1385650171-8756-1-git-send-email-b.brezillon@overkiz.com> <1385650228-8906-1-git-send-email-b.brezillon@overkiz.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1385650228-8906-1-git-send-email-b.brezillon-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Boris BREZILLON , Russell King , Nicolas Ferre , Mike Turquette , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thursday 28 November 2013, Boris BREZILLON wrote: > @@ -92,6 +103,8 @@ > dma-names = "tx", "rx"; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_spi0>; > + clocks = <&spi0_clk>; > + clock-names = "spi_clk"; > status = "disabled"; > }; > > @@ -101,6 +114,8 @@ > interrupts = <38 IRQ_TYPE_LEVEL_HIGH 4>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_ssc0_tx &pinctrl_ssc0_rx>; > + clocks = <&ssc0_clk>; > + clock-names = "pclk"; > status = "disabled"; > }; > You are adding "clock-names" properties in a lot of cases. Are you sure you are using the strings that are documented in the respective device bindings for each name? In a lot of cases, drivers just want an anonymous clock and we don't name them. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html