From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerhard Sittig Subject: Re: [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node Date: Tue, 10 Dec 2013 11:05:01 +0100 Message-ID: <20131210100501.GO2982@book.gsilab.sittig.org> References: <1386068212-11484-1-git-send-email-gsi@denx.de> <20131203150432.2c326004@crub> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20131203150432.2c326004@crub> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Anatolij Gustschin Cc: devicetree@vger.kernel.org, matteo.facchinetti@sirius-es.it, linuxppc-dev@lists.ozlabs.org List-Id: devicetree@vger.kernel.org [ Cc: to Matteo as well ] On Tue, Dec 03, 2013 at 15:04 +0100, Anatolij Gustschin wrote: > > On Tue, 3 Dec 2013 11:56:52 +0100 > Gerhard Sittig wrote: > > > the 'soc' node in the common .dtsi for MPC5121 has an '#interrupt-cells' > > property although this node is not an interrupt controller > > > > remove this erroneously placed property because starting with v3.13-rc1 > > lookup and resolution of 'interrupts' specs for peripherals gets misled, > > emits 'no irq domain found' WARN() messages and breaks the boot process > > > > irq: no irq domain found for /soc@80000000 ! > > ------------[ cut here ]------------ > > WARNING: at /home/gsi/SRC/linux-torvalds/drivers/of/platform.c:171 > > [ ... ] > > > > ... > > irq: no irq domain found for /soc@80000000 ! > > fsl-diu-fb 80002100.display: could not get DIU IRQ > > fsl-diu-fb: probe of 80002100.display failed with error -22 > > irq: no irq domain found for /soc@80000000 ! > > mpc512x_dma 80014000.dma: Error mapping IRQ! > > mpc512x_dma: probe of 80014000.dma failed with error -22 > > ... > > irq: no irq domain found for /soc@80000000 ! > > fs_enet: probe of 80002800.ethernet failed with error -22 > > ... > > irq: no irq domain found for /soc@80000000 ! > > mpc5121-rtc 80000a00.rtc: mpc5121_rtc_probe: could not request irq: 0 > > mpc5121-rtc: probe of 80000a00.rtc failed with error -22 > > ... > > > > [ best viewed with 'git diff -U5' to have DT node names in the context ] > > > > Cc: Anatolij Gustschin > > Cc: linuxppc-dev@lists.ozlabs.org > > Cc: devicetree@vger.kernel.org > > Signed-off-by: Gerhard Sittig > > --- > > arch/powerpc/boot/dts/mpc5121.dtsi | 1 - > > 1 file changed, 1 deletion(-) > > applied, thanks! FYI: I only noticed yesterday that MPC5125 suffers from the same issue, have sent <1386669068-2477-1-git-send-email-gsi@denx.de> to fix that as well. Both patches may get squashed when going upstream. Don't have a dump at hand for MPC5125 as I don't have access to hardware. Matteo, can you verify that an unpatched v3.13-rc1 (up to and including -rc3) won't boot, and that the patch fixes the issue for you? Forgot to Cc: you on the MPC5125 patch, will bounce it to you. Thanks! virtually yours Gerhard Sittig -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de