* [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node
@ 2013-12-03 10:56 Gerhard Sittig
2013-12-03 14:04 ` Anatolij Gustschin
0 siblings, 1 reply; 4+ messages in thread
From: Gerhard Sittig @ 2013-12-03 10:56 UTC (permalink / raw)
To: Anatolij Gustschin
Cc: Gerhard Sittig, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
devicetree-u79uwXL29TY76Z2rM5mHXA
the 'soc' node in the common .dtsi for MPC5121 has an '#interrupt-cells'
property although this node is not an interrupt controller
remove this erroneously placed property because starting with v3.13-rc1
lookup and resolution of 'interrupts' specs for peripherals gets misled,
emits 'no irq domain found' WARN() messages and breaks the boot process
irq: no irq domain found for /soc@80000000 !
------------[ cut here ]------------
WARNING: at /home/gsi/SRC/linux-torvalds/drivers/of/platform.c:171
Modules linked in:
CPU: 0 PID: 1 Comm: swapper Tainted: G W 3.13.0-rc1-00001-g8a66234 #8
task: df823bb0 ti: df834000 task.ti: df834000
NIP: c02b5190 LR: c02b5180 CTR: c01cf4e0
REGS: df835c50 TRAP: 0700 Tainted: G W (3.13.0-rc1-00001-g8a66234)
MSR: 00029032 <EE,ME,IR,DR,RI> CR: 229a9d42 XER: 20000000
GPR00: c02b5180 df835d00 df823bb0 00000000 00000000 df835b18 ffffffff 00000308
GPR08: c0479cc0 c0480000 c0479cc0 00000308 00000308 00000000 c00040fc 00000000
GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 df850880
GPR24: df84d670 00000000 00000001 df8561a0 dffffccc df85089c 00000020 00000001
NIP [c02b5190] of_device_alloc+0xf4/0x1a0
LR [c02b5180] of_device_alloc+0xe4/0x1a0
Call Trace:
[df835d00] [c02b5180] of_device_alloc+0xe4/0x1a0 (unreliable)
[df835d50] [c02b5278] of_platform_device_create_pdata+0x3c/0xc8
[df835d70] [c02b53fc] of_platform_bus_create+0xf8/0x170
[df835dc0] [c02b5448] of_platform_bus_create+0x144/0x170
[df835e10] [c02b55a8] of_platform_bus_probe+0x98/0xe8
[df835e30] [c0437508] mpc512x_init+0x28/0x1c4
[df835e70] [c0435de8] ppc_init+0x4c/0x60
[df835e80] [c0003b28] do_one_initcall+0x150/0x1a4
[df835ef0] [c0432048] kernel_init_freeable+0x114/0x1c0
[df835f30] [c0004114] kernel_init+0x18/0x124
[df835f40] [c000e910] ret_from_kernel_thread+0x5c/0x64
Instruction dump:
409effd4 57c9103a 57de2834 7c89f050 7f83e378 7c972214 7f45d378 48001f55
7c63d278 7c630034 5463d97e 687a0001 <0f1a0000> 2f990000 387b0010 939b0098
---[ end trace 2257f10e5a20cbdd ]---
...
irq: no irq domain found for /soc@80000000 !
fsl-diu-fb 80002100.display: could not get DIU IRQ
fsl-diu-fb: probe of 80002100.display failed with error -22
irq: no irq domain found for /soc@80000000 !
mpc512x_dma 80014000.dma: Error mapping IRQ!
mpc512x_dma: probe of 80014000.dma failed with error -22
...
irq: no irq domain found for /soc@80000000 !
fs_enet: probe of 80002800.ethernet failed with error -22
...
irq: no irq domain found for /soc@80000000 !
mpc5121-rtc 80000a00.rtc: mpc5121_rtc_probe: could not request irq: 0
mpc5121-rtc: probe of 80000a00.rtc failed with error -22
...
[ best viewed with 'git diff -U5' to have DT node names in the context ]
Cc: Anatolij Gustschin <agust-ynQEQJNshbs@public.gmane.org>
Cc: linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Gerhard Sittig <gsi-ynQEQJNshbs@public.gmane.org>
---
arch/powerpc/boot/dts/mpc5121.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/boot/dts/mpc5121.dtsi b/arch/powerpc/boot/dts/mpc5121.dtsi
index bd14c00e5146..2d7cb04ac962 100644
--- a/arch/powerpc/boot/dts/mpc5121.dtsi
+++ b/arch/powerpc/boot/dts/mpc5121.dtsi
@@ -75,11 +75,10 @@
soc@80000000 {
compatible = "fsl,mpc5121-immr";
#address-cells = <1>;
#size-cells = <1>;
- #interrupt-cells = <2>;
ranges = <0x0 0x80000000 0x400000>;
reg = <0x80000000 0x400000>;
bus-frequency = <66000000>; /* 66 MHz ips bus */
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node
2013-12-03 10:56 [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node Gerhard Sittig
@ 2013-12-03 14:04 ` Anatolij Gustschin
2013-12-10 10:05 ` Gerhard Sittig
0 siblings, 1 reply; 4+ messages in thread
From: Anatolij Gustschin @ 2013-12-03 14:04 UTC (permalink / raw)
To: Gerhard Sittig; +Cc: devicetree, linuxppc-dev
On Tue, 3 Dec 2013 11:56:52 +0100
Gerhard Sittig <gsi@denx.de> wrote:
> the 'soc' node in the common .dtsi for MPC5121 has an '#interrupt-cells'
> property although this node is not an interrupt controller
>
> remove this erroneously placed property because starting with v3.13-rc1
> lookup and resolution of 'interrupts' specs for peripherals gets misled,
> emits 'no irq domain found' WARN() messages and breaks the boot process
>
> irq: no irq domain found for /soc@80000000 !
> ------------[ cut here ]------------
> WARNING: at /home/gsi/SRC/linux-torvalds/drivers/of/platform.c:171
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper Tainted: G W 3.13.0-rc1-00001-g8a66234 #8
> task: df823bb0 ti: df834000 task.ti: df834000
> NIP: c02b5190 LR: c02b5180 CTR: c01cf4e0
> REGS: df835c50 TRAP: 0700 Tainted: G W (3.13.0-rc1-00001-g8a66234)
> MSR: 00029032 <EE,ME,IR,DR,RI> CR: 229a9d42 XER: 20000000
>
> GPR00: c02b5180 df835d00 df823bb0 00000000 00000000 df835b18 ffffffff 00000308
> GPR08: c0479cc0 c0480000 c0479cc0 00000308 00000308 00000000 c00040fc 00000000
> GPR16: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 df850880
> GPR24: df84d670 00000000 00000001 df8561a0 dffffccc df85089c 00000020 00000001
> NIP [c02b5190] of_device_alloc+0xf4/0x1a0
> LR [c02b5180] of_device_alloc+0xe4/0x1a0
> Call Trace:
> [df835d00] [c02b5180] of_device_alloc+0xe4/0x1a0 (unreliable)
> [df835d50] [c02b5278] of_platform_device_create_pdata+0x3c/0xc8
> [df835d70] [c02b53fc] of_platform_bus_create+0xf8/0x170
> [df835dc0] [c02b5448] of_platform_bus_create+0x144/0x170
> [df835e10] [c02b55a8] of_platform_bus_probe+0x98/0xe8
> [df835e30] [c0437508] mpc512x_init+0x28/0x1c4
> [df835e70] [c0435de8] ppc_init+0x4c/0x60
> [df835e80] [c0003b28] do_one_initcall+0x150/0x1a4
> [df835ef0] [c0432048] kernel_init_freeable+0x114/0x1c0
> [df835f30] [c0004114] kernel_init+0x18/0x124
> [df835f40] [c000e910] ret_from_kernel_thread+0x5c/0x64
> Instruction dump:
> 409effd4 57c9103a 57de2834 7c89f050 7f83e378 7c972214 7f45d378 48001f55
> 7c63d278 7c630034 5463d97e 687a0001 <0f1a0000> 2f990000 387b0010 939b0098
> ---[ end trace 2257f10e5a20cbdd ]---
>
> ...
> irq: no irq domain found for /soc@80000000 !
> fsl-diu-fb 80002100.display: could not get DIU IRQ
> fsl-diu-fb: probe of 80002100.display failed with error -22
> irq: no irq domain found for /soc@80000000 !
> mpc512x_dma 80014000.dma: Error mapping IRQ!
> mpc512x_dma: probe of 80014000.dma failed with error -22
> ...
> irq: no irq domain found for /soc@80000000 !
> fs_enet: probe of 80002800.ethernet failed with error -22
> ...
> irq: no irq domain found for /soc@80000000 !
> mpc5121-rtc 80000a00.rtc: mpc5121_rtc_probe: could not request irq: 0
> mpc5121-rtc: probe of 80000a00.rtc failed with error -22
> ...
>
> [ best viewed with 'git diff -U5' to have DT node names in the context ]
>
> Cc: Anatolij Gustschin <agust@denx.de>
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Gerhard Sittig <gsi@denx.de>
> ---
> arch/powerpc/boot/dts/mpc5121.dtsi | 1 -
> 1 file changed, 1 deletion(-)
applied, thanks!
Anatolij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node
2013-12-03 14:04 ` Anatolij Gustschin
@ 2013-12-10 10:05 ` Gerhard Sittig
[not found] ` <20131210100501.GO2982-kDjWylLy9wD0K7fsECOQyeGNnDKD8DIp@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Gerhard Sittig @ 2013-12-10 10:05 UTC (permalink / raw)
To: Anatolij Gustschin; +Cc: devicetree, matteo.facchinetti, linuxppc-dev
[ Cc: to Matteo as well ]
On Tue, Dec 03, 2013 at 15:04 +0100, Anatolij Gustschin wrote:
>
> On Tue, 3 Dec 2013 11:56:52 +0100
> Gerhard Sittig <gsi@denx.de> wrote:
>
> > the 'soc' node in the common .dtsi for MPC5121 has an '#interrupt-cells'
> > property although this node is not an interrupt controller
> >
> > remove this erroneously placed property because starting with v3.13-rc1
> > lookup and resolution of 'interrupts' specs for peripherals gets misled,
> > emits 'no irq domain found' WARN() messages and breaks the boot process
> >
> > irq: no irq domain found for /soc@80000000 !
> > ------------[ cut here ]------------
> > WARNING: at /home/gsi/SRC/linux-torvalds/drivers/of/platform.c:171
> > [ ... ]
> >
> > ...
> > irq: no irq domain found for /soc@80000000 !
> > fsl-diu-fb 80002100.display: could not get DIU IRQ
> > fsl-diu-fb: probe of 80002100.display failed with error -22
> > irq: no irq domain found for /soc@80000000 !
> > mpc512x_dma 80014000.dma: Error mapping IRQ!
> > mpc512x_dma: probe of 80014000.dma failed with error -22
> > ...
> > irq: no irq domain found for /soc@80000000 !
> > fs_enet: probe of 80002800.ethernet failed with error -22
> > ...
> > irq: no irq domain found for /soc@80000000 !
> > mpc5121-rtc 80000a00.rtc: mpc5121_rtc_probe: could not request irq: 0
> > mpc5121-rtc: probe of 80000a00.rtc failed with error -22
> > ...
> >
> > [ best viewed with 'git diff -U5' to have DT node names in the context ]
> >
> > Cc: Anatolij Gustschin <agust@denx.de>
> > Cc: linuxppc-dev@lists.ozlabs.org
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Gerhard Sittig <gsi@denx.de>
> > ---
> > arch/powerpc/boot/dts/mpc5121.dtsi | 1 -
> > 1 file changed, 1 deletion(-)
>
> applied, thanks!
FYI: I only noticed yesterday that MPC5125 suffers from the same
issue, have sent <1386669068-2477-1-git-send-email-gsi@denx.de>
to fix that as well. Both patches may get squashed when going
upstream. Don't have a dump at hand for MPC5125 as I don't have
access to hardware.
Matteo, can you verify that an unpatched v3.13-rc1 (up to and
including -rc3) won't boot, and that the patch fixes the issue
for you? Forgot to Cc: you on the MPC5125 patch, will bounce it
to you. Thanks!
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node
[not found] ` <20131210100501.GO2982-kDjWylLy9wD0K7fsECOQyeGNnDKD8DIp@public.gmane.org>
@ 2013-12-10 11:24 ` Gerhard Sittig
0 siblings, 0 replies; 4+ messages in thread
From: Gerhard Sittig @ 2013-12-10 11:24 UTC (permalink / raw)
To: Anatolij Gustschin, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ,
devicetree-u79uwXL29TY76Z2rM5mHXA,
matteo.facchinetti-rF44gyYGg1k3ahhDiVHSzw
On Tue, Dec 10, 2013 at 11:05 +0100, Gerhard Sittig wrote:
>
> FYI: I only noticed yesterday that MPC5125 suffers from the same
> issue, have sent <1386669068-2477-1-git-send-email-gsi-ynQEQJNshbs@public.gmane.org>
> to fix that as well. Both patches may get squashed when going
> upstream. Don't have a dump at hand for MPC5125 as I don't have
> access to hardware.
Had a thinko there, the MPC5121 fix already went upstream, while
the MPC5125 fix is pending. So there is no squashing. Nevermind.
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office-ynQEQJNshbs@public.gmane.org
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-12-10 11:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-03 10:56 [PATCH v1 1/1] powerpc/512x: dts: remove misplaced IRQ spec from 'soc' node Gerhard Sittig
2013-12-03 14:04 ` Anatolij Gustschin
2013-12-10 10:05 ` Gerhard Sittig
[not found] ` <20131210100501.GO2982-kDjWylLy9wD0K7fsECOQyeGNnDKD8DIp@public.gmane.org>
2013-12-10 11:24 ` Gerhard Sittig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).