From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/5] Phy: DT binding documentation for Marvell MVEBU SATA phy. Date: Tue, 10 Dec 2013 23:59:00 +0100 Message-ID: <20131210225900.GB17875@lunn.ch> References: <1386177364-10164-1-git-send-email-andrew@lunn.ch> <1386177364-10164-2-git-send-email-andrew@lunn.ch> <52A01742.2080405@ti.com> <20131205094319.GD10498@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20131205094319.GD10498@lunn.ch> Sender: linux-ide-owner@vger.kernel.org To: Andrew Lunn , kishon@ti.com Cc: Jason Cooper , devicetree@vger.kernel.org, linux-ide@vger.kernel.org, Gregory Clement , Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org On Thu, Dec 05, 2013 at 10:43:19AM +0100, Andrew Lunn wrote: > > > Example: > > > > > > sata@80000 { > > > compatible = "marvell,orion-sata"; > > > reg = <0x80000 0x5000>; > > > interrupts = <21>; > > > + phys = <&sata_phy0>, <&sata_phy1>; > > > + phy-names = "0", "1"; > > > > more descriptive phy-names? sata-phy0? > > > nr-ports = <2>; > > I could do, but i was following how the clocks work. Unfortunately, > the binding documentation is out of date and does not contain > clocks. A real example is: > > sata@80000 { > compatible = "marvell,orion-sata"; > reg = <0x80000 0x5000>; > interrupts = <21>; > clocks = <&gate_clk 14>, <&gate_clk 15>; > clock-names = "0", "1"; > phys = <&sata_phy0>, <&sata_phy1>; > phy-names = "0", "1"; > status = "disabled"; > }; > > So clocks and the phy are described nearly identically. I can however > handle phys differently if you wish. Hi Kishon Please could you comment on this. Are you O.K. if i use the same naming scheme for phys as clocks? Thanks Andrew