From: Arnd Bergmann <arnd@arndb.de>
To: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: devicetree@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
patches@linaro.org, Seungwon Jeon <tgih.jun@samsung.com>,
linux-mmc@vger.kernel.org, Jaehoon Chung <jh80.chung@samsung.com>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Kumar Gala <galak@codeaurora.org>, Chris Ball <cjb@laptop.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] clk: hisilicon: add hi3620_mmc_clks
Date: Wed, 11 Dec 2013 15:44:47 +0100 [thread overview]
Message-ID: <201312111544.47519.arnd@arndb.de> (raw)
In-Reply-To: <1386770541-15056-4-git-send-email-zhangfei.gao@linaro.org>
On Wednesday 11 December 2013, Zhangfei Gao wrote:
> +PCTRL: Peripheral misc control register
> +
> +Required Properties:
> +- compatible: "hisilicon,pctrl"
> +- reg: Address and size of pctrl.
> +
> +Example:
> +
> + /* for Hi3620 */
> + pctrl: pctrl@fca09000 {
> + compatible = "hisilicon,pctrl";
> + reg = <0xfca09000 0x1000>;
> + };
It seems you are missing the clock specific parts of the binding:
You should document the required value of #clock-cells as well as
the possible values for the clock specifier.
Arnd
next prev parent reply other threads:[~2013-12-11 14:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-11 14:02 [PATCH v4 0/3] mmc: dw_mmc: add dw_mmc-k3 Zhangfei Gao
2013-12-11 14:02 ` [PATCH 1/3] mmc: dw_mmc: use slot-gpio to handle cd pin Zhangfei Gao
2013-12-11 14:02 ` [PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform Zhangfei Gao
2013-12-11 14:49 ` Arnd Bergmann
2013-12-11 15:36 ` zhangfei
2013-12-11 15:53 ` zhangfei
2013-12-11 20:12 ` Arnd Bergmann
[not found] ` <201312112112.52746.arnd-r2nGTMty4D4@public.gmane.org>
2013-12-12 13:27 ` zhangfei
2013-12-12 14:13 ` Zhangfei Gao
2013-12-12 20:40 ` Arnd Bergmann
2013-12-13 2:57 ` zhangfei
2013-12-11 14:02 ` [PATCH 3/3] clk: hisilicon: add hi3620_mmc_clks Zhangfei Gao
2013-12-11 14:44 ` Arnd Bergmann [this message]
2013-12-11 15:40 ` zhangfei
-- strict thread matches above, loose matches on Subject: below --
2013-12-14 2:12 [PATCH v5 0/3] mmc: dw_mmc: add dw_mmc-k3 Zhangfei Gao
2013-12-14 2:12 ` [PATCH 3/3] clk: hisilicon: add hi3620_mmc_clks Zhangfei Gao
2013-12-28 14:34 [PATCH v6 0/3] mmc: dw_mmc: add dw_mmc-k3 Zhangfei Gao
2013-12-28 14:34 ` [PATCH 3/3] clk: hisilicon: add hi3620_mmc_clks Zhangfei Gao
2014-01-09 14:35 [PATCH v7 0/3] mmc: dw_mmc: add dw_mmc-k3 Zhangfei Gao
2014-01-09 14:35 ` [PATCH 3/3] clk: hisilicon: add hi3620_mmc_clks Zhangfei Gao
2014-01-09 14:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201312111544.47519.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=haojian.zhuang@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=patches@linaro.org \
--cc=tgih.jun@samsung.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).