From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Porter Subject: Re: [PATCH v5 3/9] usb: gadget: s3c-hsotg: enable build for other platforms Date: Thu, 12 Dec 2013 17:07:26 -0500 Message-ID: <20131212220726.GA4205@beef> References: <1386854770-2173-1-git-send-email-mporter@linaro.org> <1386854770-2173-4-git-send-email-mporter@linaro.org> <52AA2FE3.3060200@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <52AA2FE3.3060200-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dinh Nguyen Cc: Felipe Balbi , Greg Kroah-Hartman , Kishon Vijay Abraham I , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , Christian Daudt , Paul Zimmerman , Devicetree List , Kamil Debski , Russell King , Linaro Patches , Tomasz Figa , Linux USB List , Linux Kernel Mailing List , Kyungmin Park , Linux ARM Kernel List List-Id: devicetree@vger.kernel.org On Thu, Dec 12, 2013 at 03:51:31PM -0600, Dinh Nguyen wrote: > Hi Matt, > > On 12/12/13 7:26 AM, Matt Porter wrote: > > Remove unused Samsung-specific machine include and Kconfig > > dependency on S3C. > > > > Signed-off-by: Matt Porter > > Reviewed-by: Markus Mayer > > Reviewed-by: Tim Kryger > > --- > > drivers/usb/gadget/Kconfig | 7 +++---- > > drivers/usb/gadget/s3c-hsotg.c | 2 -- > > 2 files changed, 3 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > > index a91e642..970bd1a 100644 > > --- a/drivers/usb/gadget/Kconfig > > +++ b/drivers/usb/gadget/Kconfig > > @@ -294,11 +294,10 @@ config USB_PXA27X > > gadget drivers to also be dynamically linked. > > > > config USB_S3C_HSOTG > > - tristate "S3C HS/OtG USB Device controller" > > - depends on S3C_DEV_USB_HSOTG > > + tristate "Designware/S3C HS/OtG USB Device controller" > > help > > - The Samsung S3C64XX USB2.0 high-speed gadget controller > > - integrated into the S3C64XX series SoC. > > + The Designware USB2.0 high-speed gadget controller > > + integrated into the S3C64XX and BCM281xx series SoC. > Thanks for doing this. The SOCFPGA platform is also using this driver. > So perhaps a > more generic message here? Ok, I wasn't aware since I didn't see anybody else try to fix this driver in mainline. How about this? The Designware USB2.0 high-speed gadget controller integrated into many SoCS. If that looks better to you I'll plan to add it in an update. I would like to see if we can gather a couple acks at this point or if there are any additional DT comments before sending another update. -Matt > > > > config USB_S3C2410 > > tristate "S3C2410 USB Device Controller" > > diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c > > index 33eb690..8ceb5ef 100644 > > --- a/drivers/usb/gadget/s3c-hsotg.c > > +++ b/drivers/usb/gadget/s3c-hsotg.c > > @@ -37,8 +37,6 @@ > > #include > > #include > > > > -#include > > - > > #include "s3c-hsotg.h" > > > > static const char * const s3c_hsotg_supply_names[] = { > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html