From: Felipe Balbi <balbi@ti.com>
To: Peter Chen <peter.chen@freescale.com>
Cc: marex@denx.de, devicetree@vger.kernel.org,
m.grzeschik@pengutronix.de, frank.li@freescale.com,
linux-doc@vger.kernel.org, alexander.shishkin@linux.intel.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
rob.herring@calxeda.com, balbi@ti.com, kernel@pengutronix.de,
grant.likely@linaro.org, shawn.guo@linaro.org,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 03/15] usb: phy-mxs: Add auto clock and power setting
Date: Thu, 12 Dec 2013 22:23:38 -0600 [thread overview]
Message-ID: <20131213042338.GD867@saruman.home> (raw)
In-Reply-To: <1386897825-6130-4-git-send-email-peter.chen@freescale.com>
[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]
On Fri, Dec 13, 2013 at 09:23:33AM +0800, Peter Chen wrote:
> With the auto setting, the PHY's clock and power can be
> recovered correctly from low power mode, it is ganranteed by IC logic.
s/ganranteed/guaranteed
Also, I think you need to be slightly more verbose here. Maybe explain a
bit what is the "auto setting". From what I can see from the code, it's
a way to let HW manage clock gating.
Another question, does this feature work in all SoCs where this IP is
available ?
cheers
--
balbi
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2013-12-13 4:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 1:23 [PATCH v6 00/15] Add power management support for mxs phy Peter Chen
2013-12-13 1:23 ` [PATCH v6 01/15] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-12-13 7:15 ` Lothar Waßmann
2013-12-13 7:24 ` Peter Chen
2013-12-13 7:38 ` Lothar Waßmann
2013-12-13 7:58 ` Peter Chen
2013-12-13 1:23 ` [PATCH v6 02/15] usb: phy-mxs: Add platform judgement code Peter Chen
2013-12-13 4:19 ` Felipe Balbi
[not found] ` <20131213041918.GC867-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2013-12-13 5:15 ` Peter Chen
2013-12-13 1:23 ` [PATCH v6 03/15] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-12-13 4:23 ` Felipe Balbi [this message]
2013-12-13 5:55 ` Peter Chen
2013-12-13 1:23 ` [PATCH v6 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-12-13 4:25 ` Felipe Balbi
[not found] ` <20131213042504.GE867-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2013-12-13 6:00 ` Peter Chen
2013-12-13 1:23 ` [PATCH v6 05/15] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
[not found] ` <1386897825-6130-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-13 1:23 ` [PATCH v6 06/15] usb: phy-mxs: Add anatop regmap Peter Chen
2013-12-13 4:26 ` Felipe Balbi
[not found] ` <20131213042627.GF867-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2013-12-13 6:04 ` Peter Chen
2013-12-13 1:23 ` [PATCH v6 07/15] usb: phy: add notify suspend and resume callback Peter Chen
[not found] ` <1386897825-6130-8-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-13 4:27 ` Felipe Balbi
[not found] ` <20131213042722.GG867-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2013-12-13 6:23 ` Peter Chen
2013-12-13 1:23 ` [PATCH v6 08/15] usb: phy-mxs: Add implementation of nofity_suspend and notify_resume Peter Chen
2013-12-13 4:32 ` Felipe Balbi
2013-12-13 6:31 ` Peter Chen
2013-12-13 20:09 ` Felipe Balbi
2013-12-16 1:12 ` Peter Chen
2013-12-16 21:31 ` Felipe Balbi
2013-12-13 1:23 ` [PATCH v6 11/15] usb: phy-mxs: add controller id Peter Chen
2013-12-13 1:23 ` [PATCH v6 13/15] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-12-13 1:23 ` [PATCH v6 14/15] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-12-13 4:38 ` Felipe Balbi
[not found] ` <20131213043838.GI867-HgARHv6XitL9zxVx7UNMDg@public.gmane.org>
2013-12-13 6:34 ` Peter Chen
2013-12-13 1:23 ` [PATCH v6 15/15] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
[not found] ` <1386897825-6130-16-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-13 4:39 ` Felipe Balbi
2013-12-13 6:50 ` Peter Chen
2013-12-13 1:23 ` [PATCH v6 09/15] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2013-12-13 1:23 ` [PATCH v6 10/15] ARM: dts: imx: add mxs phy controller id Peter Chen
2013-12-13 1:23 ` [PATCH v6 12/15] usb: phy: Add set_wakeup API Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131213042338.GD867@saruman.home \
--to=balbi@ti.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@freescale.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=marex@denx.de \
--cc=peter.chen@freescale.com \
--cc=rob.herring@calxeda.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).