From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v7 8/9] phy: add Broadcom Kona USB2 PHY driver Date: Wed, 18 Dec 2013 10:25:54 -0600 Message-ID: <20131218162554.GF4970@saruman.home> References: <1387309356-17195-1-git-send-email-mporter@linaro.org> <1387309356-17195-9-git-send-email-mporter@linaro.org> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Wtrm9ATX0sn6fFKv" Return-path: Content-Disposition: inline In-Reply-To: <1387309356-17195-9-git-send-email-mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matt Porter Cc: Felipe Balbi , Greg Kroah-Hartman , Kishon Vijay Abraham I , Rob Herring , Pawel Moll , Mark Rutland , Kumar Gala , Ian Campbell , Christian Daudt , Paul Zimmerman , Tomasz Figa , Kamil Debski , Kyungmin Park , Dinh Nguyen , Russell King , Linux USB List , Linux ARM Kernel List , Linux Kernel Mailing List , Devicetree List , Linaro Patches List-Id: devicetree@vger.kernel.org --Wtrm9ATX0sn6fFKv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 17, 2013 at 02:42:35PM -0500, Matt Porter wrote: > Add a driver for the internal Broadcom Kona USB 2.0 PHY found > on the BCM281xx family of SoCs. >=20 > Signed-off-by: Matt Porter Kishon, are you ok with this driver ? > +static int bcm_kona_usb2_probe(struct platform_device *pdev) > +{ > + struct device *dev =3D &pdev->dev; > + struct bcm_kona_usb *phy; > + struct resource *res; > + struct phy *gphy; > + struct phy_provider *phy_provider; > + > + phy =3D devm_kzalloc(dev, sizeof(*phy), GFP_KERNEL); > + if (!phy) > + return -ENOMEM; > + > + res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > + phy->regs =3D devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(phy->regs)) > + return PTR_ERR(phy->regs); > + > + platform_set_drvdata(pdev, phy); > + > + phy_provider =3D devm_of_phy_provider_register(dev, > + of_phy_simple_xlate); > + if (IS_ERR(phy_provider)) > + return PTR_ERR(phy_provider); > + > + gphy =3D devm_phy_create(dev, &ops, NULL); > + if (IS_ERR(gphy)) > + return PTR_ERR(gphy); > + > + /* The Kona PHY supports an 8-bit wide UTMI interface */ > + phy_set_bus_width(gphy, 8); > + > + phy_set_drvdata(gphy, phy); I think this set_drvdata() should be done before registering the provider, no ? --=20 balbi --Wtrm9ATX0sn6fFKv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBAgAGBQJSscySAAoJEIaOsuA1yqREK1sP/AtELOQS47cAHu1WkxAIyW4N k9gSqKh5l7yhAx/ynetfmV/F24ytX+ibr3kLsAYtyZxDn4JB9HZY+AeyCvLLbJwB +QrCX++fHLodN4cpx88Q+vXMZtaUlWIFbw2N2wBDi4i/urKwx5e8MWX47S3AkxLm kI4q1Qnsuls34zOTKQUSSyUACYjAboQntHTa3qLlvAODapBRTAn3vpf1Z/7ze3Mx u+l/1Mj9CXMA70CfrYX4BCZico/anrM/ZhGflfuwmB+vEuhDv62FvuqC3g6aPnNw jnsglam6KTCKyKrQIwqLbGSSE/49PDuO02sZPKnpOe+D4lUiSyMK6uW8zn+KH4h5 A6n2Ru0PHRNTpTsCIKG3AkCfujDyxeLbiCb0NZuyG3U/tNJDWLDlbcsicgzIGQEG fJrQnWwL6z4+8EaLbhXKcWIFSS8J7HbTkwtdGlCaoCZHBo0WNTNcpcBGs26l22iS xIb2JznDgEt6wz4HakXqmsP8q4Dg52jvUGqzmV3ziF94Oulr2lTLqZkFnJkzqBct fABDRSXehWlXoxMjEwUuBReOIlj4ZTzuTT2ZFQkWiFc42I5HmPywKSNMizzElkQ5 LpOqQjU/ZSf+YcfcLH0ams9nBfe7XIycr6ReV51gRlbr9VvcrjjFLOkPftfSjpPt jNDa8rNjZnF9Af/Jnnur =Ay/j -----END PGP SIGNATURE----- --Wtrm9ATX0sn6fFKv-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html