devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: devicetree@vger.kernel.org, kernel@pengutronix.de,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Markus Pargmann" <mpa@pengutronix.de>,
	linux-omap@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/6] net: cpsw: Support for am335x chip MACIDs
Date: Wed, 18 Dec 2013 11:08:18 -0600	[thread overview]
Message-ID: <20131218170818.GR4970@saruman.home> (raw)
In-Reply-To: <52B1D4C7.6030004@ti.com>


[-- Attachment #1.1: Type: text/plain, Size: 2182 bytes --]

On Wed, Dec 18, 2013 at 10:30:55PM +0530, Mugunthan V N wrote:
> On Wednesday 18 December 2013 10:17 PM, Markus Pargmann wrote:
> > Hi,
> >
> > This series introduces a driver to read and use the MACIDs stored in the am335x
> > control module. These are read-only registers for a unique MACID. At the moment
> > the MACIDs are generated randomly or they are set by the bootloader.
> >
> > A device node is added in am33xx dtsi and used by the cpsw slaves in the bone
> > board files.
> >
> > Regards,
> >
> > Markus
> >
> >
> > Markus Pargmann (6):
> >   DT doc: net: cpsw mac-address is optional
> >   net: cpsw: header, Add missing include
> >   net: cpsw: Add control-module macid driver
> >   net: cpsw: Use cpsw-ctrl-macid driver
> >   arm: dts: am33xx, Add device node for cpsw-ctrl-macid
> >   arm: dts: am335x beagle bone use processor macids
> >
> >  .../devicetree/bindings/net/cpsw-ctrl-macid.txt    |  31 +++++
> >  Documentation/devicetree/bindings/net/cpsw.txt     |   7 +-
> >  arch/arm/boot/dts/am335x-bone.dts                  |   8 ++
> >  arch/arm/boot/dts/am335x-boneblack.dts             |   8 ++
> >  arch/arm/boot/dts/am33xx.dtsi                      |   7 ++
> >  drivers/net/ethernet/ti/Kconfig                    |   8 ++
> >  drivers/net/ethernet/ti/Makefile                   |   1 +
> >  drivers/net/ethernet/ti/cpsw-ctrl-macid.c          | 138 +++++++++++++++++++++
> >  drivers/net/ethernet/ti/cpsw.c                     |  18 ++-
> >  drivers/net/ethernet/ti/cpsw.h                     |   3 +
> >  10 files changed, 224 insertions(+), 5 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/net/cpsw-ctrl-macid.txt
> >  create mode 100644 drivers/net/ethernet/ti/cpsw-ctrl-macid.c
> >
> Mac ID is to be filled by U-Boot and this kind of approach is already
> rejected in linux-omap list.
> 
> If proper ethaddr/eth*addr is populated in U-boot environment variable
> then mac-address dt property in ethernet* device nodes will be populated
> before boot kernel in U-boot. So I don't think this patch series is
> required.

but will u-boot read MACID from control module ?

-- 
balbi

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2013-12-18 17:08 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18 16:47 [PATCH 0/6] net: cpsw: Support for am335x chip MACIDs Markus Pargmann
2013-12-18 16:47 ` [PATCH 1/6] DT doc: net: cpsw mac-address is optional Markus Pargmann
2013-12-18 16:47 ` [PATCH 2/6] net: cpsw: header, Add missing include Markus Pargmann
2013-12-18 16:47 ` [PATCH 3/6] net: cpsw: Add control-module macid driver Markus Pargmann
     [not found]   ` <1387385242-1161-4-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-02-13 19:44     ` Uwe Kleine-König
2014-02-14  9:32       ` Markus Pargmann
     [not found] ` <1387385242-1161-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2013-12-18 16:47   ` [PATCH 4/6] net: cpsw: Use cpsw-ctrl-macid driver Markus Pargmann
2014-02-13 19:37     ` Uwe Kleine-König
2014-02-14  9:23       ` Markus Pargmann
2013-12-18 16:47 ` [PATCH 5/6] arm: dts: am33xx, Add device node for cpsw-ctrl-macid Markus Pargmann
2013-12-18 16:47 ` [PATCH 6/6] arm: dts: am335x beagle bone use processor macids Markus Pargmann
2014-02-13 19:47   ` Uwe Kleine-König
2013-12-18 17:00 ` [PATCH 0/6] net: cpsw: Support for am335x chip MACIDs Mugunthan V N
2013-12-18 17:08   ` Felipe Balbi [this message]
2013-12-18 17:10     ` Mugunthan V N
2013-12-18 17:13       ` Felipe Balbi
2014-02-13 19:33         ` Uwe Kleine-König
2013-12-19  8:19       ` Markus Pargmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131218170818.GR4970@saruman.home \
    --to=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mpa@pengutronix.de \
    --cc=mugunthanvnm@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).