From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH 0/6] net: cpsw: Support for am335x chip MACIDs Date: Wed, 18 Dec 2013 11:13:01 -0600 Message-ID: <20131218171301.GT4970@saruman.home> References: <1387385242-1161-1-git-send-email-mpa@pengutronix.de> <52B1D4C7.6030004@ti.com> <20131218170818.GR4970@saruman.home> <52B1D722.3040500@ti.com> Reply-To: balbi@ti.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5708122643770003982==" Return-path: In-Reply-To: <52B1D722.3040500@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Mugunthan V N Cc: devicetree@vger.kernel.org, kernel@pengutronix.de, balbi@ti.com, =?iso-8859-1?Q?Beno=EEt?= Cousson , Markus Pargmann , linux-omap@vger.kernel.org, "David S. Miller" , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org --===============5708122643770003982== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Hy4a9G0dOYssRJVI" Content-Disposition: inline --Hy4a9G0dOYssRJVI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 18, 2013 at 10:40:58PM +0530, Mugunthan V N wrote: > On Wednesday 18 December 2013 10:38 PM, Felipe Balbi wrote: > > On Wed, Dec 18, 2013 at 10:30:55PM +0530, Mugunthan V N wrote: > >> On Wednesday 18 December 2013 10:17 PM, Markus Pargmann wrote: > >>> Hi, > >>> > >>> This series introduces a driver to read and use the MACIDs stored in = the am335x > >>> control module. These are read-only registers for a unique MACID. At = the moment > >>> the MACIDs are generated randomly or they are set by the bootloader. > >>> > >>> A device node is added in am33xx dtsi and used by the cpsw slaves in = the bone > >>> board files. > >>> > >>> Regards, > >>> > >>> Markus > >>> > >>> > >>> Markus Pargmann (6): > >>> DT doc: net: cpsw mac-address is optional > >>> net: cpsw: header, Add missing include > >>> net: cpsw: Add control-module macid driver > >>> net: cpsw: Use cpsw-ctrl-macid driver > >>> arm: dts: am33xx, Add device node for cpsw-ctrl-macid > >>> arm: dts: am335x beagle bone use processor macids > >>> > >>> .../devicetree/bindings/net/cpsw-ctrl-macid.txt | 31 +++++ > >>> Documentation/devicetree/bindings/net/cpsw.txt | 7 +- > >>> arch/arm/boot/dts/am335x-bone.dts | 8 ++ > >>> arch/arm/boot/dts/am335x-boneblack.dts | 8 ++ > >>> arch/arm/boot/dts/am33xx.dtsi | 7 ++ > >>> drivers/net/ethernet/ti/Kconfig | 8 ++ > >>> drivers/net/ethernet/ti/Makefile | 1 + > >>> drivers/net/ethernet/ti/cpsw-ctrl-macid.c | 138 +++++++++++= ++++++++++ > >>> drivers/net/ethernet/ti/cpsw.c | 18 ++- > >>> drivers/net/ethernet/ti/cpsw.h | 3 + > >>> 10 files changed, 224 insertions(+), 5 deletions(-) > >>> create mode 100644 Documentation/devicetree/bindings/net/cpsw-ctrl-m= acid.txt > >>> create mode 100644 drivers/net/ethernet/ti/cpsw-ctrl-macid.c > >>> > >> Mac ID is to be filled by U-Boot and this kind of approach is already > >> rejected in linux-omap list. > >> > >> If proper ethaddr/eth*addr is populated in U-boot environment variable > >> then mac-address dt property in ethernet* device nodes will be populat= ed > >> before boot kernel in U-boot. So I don't think this patch series is > >> required. > > but will u-boot read MACID from control module ? > > > Yes, U-Boot will read the MACID from control module and if a customer > wants to have his own MACID, U-boot ENV variable ethaddr/eth1addr must > be updated. cool, then I agree this series shouldn't be applied ;-) --=20 balbi --Hy4a9G0dOYssRJVI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBAgAGBQJSsdedAAoJEIaOsuA1yqREeZYP+gPkmJScNGaeYfO2tFQ9pjVe 5PxD4WnF/nK8LRXPY7RANN8kc6A0jcG+/J/sR0T4vGdOA9H8qXSjHiNBC1UNDLHM B44vsIzcFVxDh6mUCcx4XnsltMbSwdBUabwQ4myKx8HtY9Oi2ViWR6QmYaBNMZ3s A9r4xllV/b8Y4d1bF92gem0RNAufI9ohIUXr/PAKtPZYI+EHkiesQeESHMUKgWQC unm1sKB6w6W5bAAU1q/ZqwJgSRX3EbfhngT9vDhgMe6udX6S4f2MKom5gt9Gxths ppgAqpD68FdEimTd+aW/vIUmKPszNcekjlbyj+ZRdZttcI5FUDFQmQP5YnFByE57 njXh2SwFsxa8N6rJYcDCOyXBHHAqY9AfkqDgSMLqlE47Qs4kHxJAPwC/FqNHINZo 3Hj6hsfT+N1ph6GPXzjDxnetKN4Sd1YB7tRgQ+QoCs0Xk1QujwWusDQ+bluaDSfO b/LcMGe22UZeGVnSMRWMAkDANYG2a+SLwlSDZlL0yKT3tDTHaiBaTkf5FBRlHk+Y nkxHvQfw08RYBn4zIZXK9yFR1w9aYez3J+TsY4WOzG0knnyfoMXm4IXDAFXFYtrF Tjf1lKvwyRRwcxOvEvD9ecsP0e/KCBFtN+m7Jz/q7ScHd1mu9fvla9ihfJRGoa1f YiYzxzdusIkIBsz20QW4 =uEq2 -----END PGP SIGNATURE----- --Hy4a9G0dOYssRJVI-- --===============5708122643770003982== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5708122643770003982==--