From: Lee Jones <lee.jones@linaro.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: anton@enomsg.org, dwmw2@infradead.org, mark.rutland@arm.com,
rob@landley.net, ijc+devicetree@hellion.org.uk,
swarren@nvidia.com, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: AS3722: add dt node properties for system power controller
Date: Thu, 19 Dec 2013 13:06:10 +0000 [thread overview]
Message-ID: <20131219130610.GI27373@lee--X1> (raw)
In-Reply-To: <1387457821-12509-1-git-send-email-ldewangan@nvidia.com>
On Thu, 19 Dec 2013, Laxman Dewangan wrote:
> ams AS3722 device supports the power off by turning off its all rails.
>
> Add dt node properties to enable this functionality on this device.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> ---
> Documentation/devicetree/bindings/mfd/as3722.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/as3722.txt b/Documentation/devicetree/bindings/mfd/as3722.txt
> index fc2191e..1e54937 100644
> --- a/Documentation/devicetree/bindings/mfd/as3722.txt
> +++ b/Documentation/devicetree/bindings/mfd/as3722.txt
> @@ -112,6 +112,15 @@ Following are properties of regulator subnode.
> ams,enable-tracking: Enable tracking with SD1, only supported
> by LDO3.
>
> +Power-off:
> +=========
> +AS3722 supports the system power off by turning off all its rail. The power off
> +is provided through pm power off.
I think pm_power_off is a Linuxisum.
> +The device node should have the following properties to enable power-off
Why is it power-off here and power off everywhere else?
> +functionality from ams AS3722:
> +ams,system-power-controller: To enable the power off functionality through
> + device.
Do what with it? "on", "<1>", something else?
> Example:
> --------
> #include <dt-bindings/mfd/as3722.h>
Should it be represented in the example?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-12-19 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 12:57 [PATCH 1/2] mfd: AS3722: add dt node properties for system power controller Laxman Dewangan
2013-12-19 12:57 ` [PATCH 2/2] power: reset: as3722: add power-off driver Laxman Dewangan
2013-12-19 13:06 ` Lee Jones [this message]
2013-12-19 19:03 ` [PATCH 1/2] mfd: AS3722: add dt node properties for system power controller Stephen Warren
2013-12-20 13:47 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131219130610.GI27373@lee--X1 \
--to=lee.jones@linaro.org \
--cc=anton@enomsg.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rob@landley.net \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).