From: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: David Laight <David.Laight-ZS65k/vG3HxXrIkS9f7CXA@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
marex-ynQEQJNshbs@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
frank.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v7 07/14] usb: phy-mxs: change description of usb device speed
Date: Mon, 23 Dec 2013 09:05:22 +0800 [thread overview]
Message-ID: <20131223010521.GA28096@shlinux1.ap.freescale.net> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B74C0-CgBM+Bx2aUAnGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
On Fri, Dec 20, 2013 at 10:40:01AM +0000, David Laight wrote:
> > From: Peter Chen
> > Sent: 20 December 2013 07:52
> > Change "high speed" to "HS"
> > Change "non-high speed" to "FS/LS"
> >
> > Implementation of notify_suspend and notify_resume will be different
> > according to mxs_phy_data->flags.
> >
> > Signed-off-by: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > ---
> > drivers/usb/phy/phy-mxs-usb.c | 8 ++++----
> > 1 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/usb/phy/phy-mxs-usb.c b/drivers/usb/phy/phy-mxs-usb.c
> > index 0ef930a..489096f 100644
> > --- a/drivers/usb/phy/phy-mxs-usb.c
> > +++ b/drivers/usb/phy/phy-mxs-usb.c
> > @@ -166,8 +166,8 @@ static int mxs_phy_suspend(struct usb_phy *x, int suspend)
> > static int mxs_phy_on_connect(struct usb_phy *phy,
> > enum usb_device_speed speed)
> > {
> > - dev_dbg(phy->dev, "%s speed device has connected\n",
> > - (speed == USB_SPEED_HIGH) ? "high" : "non-high");
> > + dev_dbg(phy->dev, "%s device has connected\n",
> > + (speed == USB_SPEED_HIGH) ? "HS" : "FS/LS");
>
> Seems you are making these messages even more cryptic.
> With all the speeds that USB supports remembering what 'full'
> means is hard enough without having a cryptic acronym.
>
We have "phy->dev" know it is a USB device, grep usb driver,
there are lots of similar naming:
$: find drivers/usb/ -name *.c | xargs grep -rn "FS/LS"
drivers/usb/host/fotg210-hcd.c:2901: /* gap is f(FS/LS transfer times) */
drivers/usb/host/ehci-sched.c:257: /* FS/LS bus bandwidth */
drivers/usb/host/xhci.c:2335: * this check is only valid for HS/FS/LS devices.
drivers/usb/host/fusbh200-hcd.c:2849: /* gap is f(FS/LS transfer times) */
drivers/usb/host/ehci-q.c:832: /* gap is f(FS/LS transfer times) */
drivers/usb/host/ehci-dbg.c:571: /* Dump all the FS/LS tables */
drivers/usb/host/ehci-dbg.c:574: "\nTT %s port %d FS/LS bandwidth allocation (us per frame)\n",
drivers/usb/host/ehci-dbg.c:589: "FS/LS budget (us per microframe)\n");
drivers/usb/host/oxu210hp-hcd.c:1414: /* gap is f(FS/LS transfer times) */
drivers/usb/gadget/fsl_udc_core.c:2101: s = "FS/LS Serial"; break;
drivers/usb/core/hcd-pci.c:132: dev_dbg(&pdev->dev, "FS/LS companion for %s\n",
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-12-23 1:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 7:51 [PATCH v7 00/14] Add power management support for mxs phy Peter Chen
2013-12-20 7:51 ` [PATCH v7 01/14] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-12-20 7:51 ` [PATCH v7 02/14] usb: phy-mxs: Add platform judgement code Peter Chen
2013-12-20 7:51 ` [PATCH v7 03/14] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-12-20 7:52 ` [PATCH v7 04/14] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-12-20 7:52 ` [PATCH v7 05/14] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
[not found] ` <1387525930-27313-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-20 7:52 ` [PATCH v7 06/14] usb: phy-mxs: Add anatop regmap Peter Chen
2013-12-24 0:15 ` Shawn Guo
2013-12-24 1:20 ` Peter Chen
[not found] ` <20131224012010.GA13518-KgLukfWpBlCctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2013-12-24 2:05 ` Shawn Guo
2013-12-20 7:52 ` [PATCH v7 07/14] usb: phy-mxs: change description of usb device speed Peter Chen
2013-12-20 10:40 ` David Laight
[not found] ` <AE90C24D6B3A694183C094C60CF0A2F6026B74C0-CgBM+Bx2aUAnGFn1LkZF6NBPR1lH4CV8@public.gmane.org>
2013-12-23 1:05 ` Peter Chen [this message]
2013-12-20 7:52 ` [PATCH v7 10/14] usb: phy-mxs: add controller id Peter Chen
2013-12-24 2:08 ` Shawn Guo
2013-12-24 1:34 ` Peter Chen
2013-12-24 2:25 ` Shawn Guo
2013-12-24 2:09 ` Peter Chen
[not found] ` <20131224020916.GC13518-KgLukfWpBlCctlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2013-12-24 2:54 ` Shawn Guo
2013-12-20 7:52 ` [PATCH v7 12/14] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-12-20 7:52 ` [PATCH v7 14/14] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
2013-12-20 7:52 ` [PATCH v7 08/14] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2013-12-20 7:52 ` [PATCH v7 09/14] ARM: dts: imx: add mxs phy controller id Peter Chen
2013-12-20 7:52 ` [PATCH v7 11/14] usb: phy: Add set_wakeup API Peter Chen
2013-12-20 7:52 ` [PATCH v7 13/14] usb: phy-mxs: Add system suspend/resume API Peter Chen
2013-12-23 16:58 ` [PATCH v7 00/14] Add power management support for mxs phy Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131223010521.GA28096@shlinux1.ap.freescale.net \
--to=peter.chen-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=David.Laight-ZS65k/vG3HxXrIkS9f7CXA@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=frank.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).