From: Mark Brown <broonie@kernel.org>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
grant.likely@linaro.org, rob.herring@calxeda.com,
linux-doc@vger.kernel.org, vpalatin@chromium.org,
nicolas.ferre@atmel.com, plagnioj@jcrosoft.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/3] regulator: act8865: add PMIC act8865 driver
Date: Mon, 23 Dec 2013 11:57:46 +0000 [thread overview]
Message-ID: <20131223115746.GR30815@sirena.org.uk> (raw)
In-Reply-To: <1387776328-23079-1-git-send-email-wenyou.yang@atmel.com>
On Mon, Dec 23, 2013 at 01:25:28PM +0800, Wenyou Yang wrote:
> +static int act8865_set_suspend_voltage(struct regulator_dev *rdev, int uV)
> +{
> + u32 selector;
> +
> + selector = regulator_map_voltage_iterate(rdev, uV, uV);
> +
> + return regulator_set_voltage_sel_regmap(rdev, selector);
> +}
This looks wrong - it's going to set the normal voltage register that is
set for runtime voltage changes. The suspend operations are only for
setting separate voltage registers, many PMICs know about system suspend
and provide separate settings for that. If this one doesn't then it
shouldn't implement this operation.
Otherwise this looked good.
next prev parent reply other threads:[~2013-12-23 11:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 5:24 [PATCH v4 0/3] regulator: act8865: add PMIC driver Wenyou Yang
2013-12-23 5:25 ` [PATCH v4 1/3] regulator: act8865: add PMIC act8865 driver Wenyou Yang
2013-12-23 11:57 ` Mark Brown [this message]
2013-12-24 2:14 ` Yang, Wenyou
[not found] ` <1387776268-23036-1-git-send-email-wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2013-12-23 5:26 ` [PATCH v4 2/3] regulator: act8865: add device tree binding doc Wenyou Yang
2013-12-23 5:27 ` [PATCH v4 3/3] ARM: dts: sama5d3xcm: add the regulator device node Wenyou Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131223115746.GR30815@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=rob.herring@calxeda.com \
--cc=vpalatin@chromium.org \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).