From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org,
shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
marex-ynQEQJNshbs@public.gmane.org,
kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
frank.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v8 11/12] usb: phy-mxs: Add system suspend/resume API
Date: Thu, 26 Dec 2013 10:25:20 -0600 [thread overview]
Message-ID: <20131226162520.GC3937@saruman.home> (raw)
In-Reply-To: <1387857536-4996-12-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
Hi,
On Tue, Dec 24, 2013 at 11:58:55AM +0800, Peter Chen wrote:
> @@ -398,6 +433,29 @@ static int mxs_phy_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static int mxs_phy_system_suspend(struct device *dev)
> +{
> + struct mxs_phy *mxs_phy = dev_get_drvdata(dev);
> +
> + if (device_may_wakeup(dev))
> + mxs_phy_enable_ldo_in_suspend(mxs_phy, true);
> +
> + return 0;
> +}
> +
> +static int mxs_phy_system_resume(struct device *dev)
> +{
> + struct mxs_phy *mxs_phy = dev_get_drvdata(dev);
> +
> + if (device_may_wakeup(dev))
> + mxs_phy_enable_ldo_in_suspend(mxs_phy, false);
> +
> + return 0;
> +}
> +
> +static SIMPLE_DEV_PM_OPS(mxs_phy_pm, mxs_phy_system_suspend,
> + mxs_phy_system_resume);
this will give "Defined but not used" warnings when !PM_SLEEP.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-12-26 16:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-24 3:58 [PATCH v8 00/12] Add power management support for mxs phy Peter Chen
2013-12-24 3:58 ` [PATCH v8 05/12] usb: phy-mxs: Add anatop regmap Peter Chen
2013-12-24 3:58 ` [PATCH v8 07/12] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
[not found] ` <1387857536-4996-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-24 3:58 ` [PATCH v8 01/12] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2013-12-24 3:58 ` [PATCH v8 02/12] usb: phy-mxs: Add platform judgement code Peter Chen
2013-12-24 3:58 ` [PATCH v8 03/12] usb: phy-mxs: Add auto clock and power setting Peter Chen
2013-12-24 3:58 ` [PATCH v8 04/12] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
2013-12-24 3:58 ` [PATCH v8 06/12] usb: phy-mxs: change description of usb device speed Peter Chen
2013-12-24 3:58 ` [PATCH v8 08/12] usb: phy-mxs: add controller id Peter Chen
2013-12-24 3:58 ` [PATCH v8 10/12] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2013-12-24 3:58 ` [PATCH v8 12/12] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
2013-12-24 3:58 ` [PATCH v8 09/12] usb: phy: Add set_wakeup API Peter Chen
2013-12-24 3:58 ` [PATCH v8 11/12] usb: phy-mxs: Add system suspend/resume API Peter Chen
[not found] ` <1387857536-4996-12-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2013-12-26 16:25 ` Felipe Balbi [this message]
2013-12-27 1:48 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131226162520.GC3937@saruman.home \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=alexander.shishkin-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=frank.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).