From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
Cc: "linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"bpringlemeir@nbsps.com" <bpringlemeir@nbsps.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jingchang Lu <jingchang.lu@freescale.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Huan Wang <Huan.Wang@freescale.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support
Date: Fri, 3 Jan 2014 15:08:26 -0800 [thread overview]
Message-ID: <20140103230826.GB13489@core.coreip.homeip.net> (raw)
In-Reply-To: <f9527d65aa234f40af2830d9fb139bbb@BY2PR03MB505.namprd03.prod.outlook.com>
On Fri, Jan 03, 2014 at 09:16:06AM +0000, Li.Xiubo@freescale.com wrote:
> Hi Dmitry,
>
> > Subject: Re: [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support
> >
> > Hi Xiubo,
> >
> > On Fri, Jan 03, 2014 at 01:24:21PM +0800, Xiubo Li wrote:
> > > +
> > > +static inline int fsl_pwm_calculate_default_ps(struct fsl_pwm_chip *fpc,
> > > + enum fsl_pwm_clk index)
> > > +{
> >
> > Why do you declare this (and other module-local) function as inline?
> > It is usually better let compiler decide if given function should be
> > inlined or not.
> >
>
> Could the compiler know when the given function should be inlined by
> not declare it?
Yes.
> And when will be inlined ?
When it makes sense to do so from compiler's point of view: i.e. it is
smallish or with single call site and there are enough registers, etc,
etc.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2014-01-03 23:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 5:24 [PATCHv8 RFC] pwm: Add Freescale FTM PWM driver support Xiubo Li
2014-01-03 7:45 ` Dmitry Torokhov
[not found] ` <20140103074511.GA10680-WlK9ik9hQGAhIp7JRqBPierSzoNAToWh@public.gmane.org>
2014-01-03 9:16 ` Li.Xiubo-KZfg59tc24xl57MIdRCFDg
2014-01-03 23:08 ` Dmitry Torokhov [this message]
2014-01-06 5:25 ` Li.Xiubo
2014-01-08 16:36 ` Bill Pringlemeir
2014-01-09 7:57 ` Li.Xiubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140103230826.GB13489@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Huan.Wang@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=bpringlemeir@nbsps.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jingchang.lu@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).