* [PATCH] ARM: dts: vf610: use the interrupt macros
@ 2013-12-25 6:19 Huang Shijie
[not found] ` <1387952367-6321-1-git-send-email-b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Huang Shijie @ 2013-12-25 6:19 UTC (permalink / raw)
To: shawn.guo; +Cc: devicetree, linux-arm-kernel, Huang Shijie
This patch uses the IRQ_TYPE_LEVEL_HIGH/IRQ_TYPE_NONE to replace
the hardcode.
Signed-off-by: Huang Shijie <b32955@freescale.com>
---
arch/arm/boot/dts/vf610.dtsi | 37 +++++++++++++++++++------------------
1 files changed, 19 insertions(+), 18 deletions(-)
diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
index ef8a0ee..cd5bb86 100644
--- a/arch/arm/boot/dts/vf610.dtsi
+++ b/arch/arm/boot/dts/vf610.dtsi
@@ -10,6 +10,7 @@
#include "skeleton.dtsi"
#include "vf610-pingrp.h"
#include <dt-bindings/clock/vf610-clock.h>
+#include <dt-bindings/interrupt-controller/irq.h>
/ {
aliases {
@@ -90,7 +91,7 @@
uart0: serial@40027000 {
compatible = "fsl,vf610-lpuart";
reg = <0x40027000 0x1000>;
- interrupts = <0 61 0x00>;
+ interrupts = <0 61 IRQ_TYPE_NONE>;
clocks = <&clks VF610_CLK_UART0>;
clock-names = "ipg";
status = "disabled";
@@ -99,7 +100,7 @@
uart1: serial@40028000 {
compatible = "fsl,vf610-lpuart";
reg = <0x40028000 0x1000>;
- interrupts = <0 62 0x04>;
+ interrupts = <0 62 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_UART1>;
clock-names = "ipg";
status = "disabled";
@@ -108,7 +109,7 @@
uart2: serial@40029000 {
compatible = "fsl,vf610-lpuart";
reg = <0x40029000 0x1000>;
- interrupts = <0 63 0x04>;
+ interrupts = <0 63 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_UART2>;
clock-names = "ipg";
status = "disabled";
@@ -117,7 +118,7 @@
uart3: serial@4002a000 {
compatible = "fsl,vf610-lpuart";
reg = <0x4002a000 0x1000>;
- interrupts = <0 64 0x04>;
+ interrupts = <0 64 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_UART3>;
clock-names = "ipg";
status = "disabled";
@@ -128,7 +129,7 @@
#size-cells = <0>;
compatible = "fsl,vf610-dspi";
reg = <0x4002c000 0x1000>;
- interrupts = <0 67 0x04>;
+ interrupts = <0 67 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_DSPI0>;
clock-names = "dspi";
spi-num-chipselects = <5>;
@@ -138,7 +139,7 @@
sai2: sai@40031000 {
compatible = "fsl,vf610-sai";
reg = <0x40031000 0x1000>;
- interrupts = <0 86 0x04>;
+ interrupts = <0 86 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_SAI2>;
clock-names = "sai";
status = "disabled";
@@ -147,7 +148,7 @@
pit: pit@40037000 {
compatible = "fsl,vf610-pit";
reg = <0x40037000 0x1000>;
- interrupts = <0 39 0x04>;
+ interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_PIT>;
clock-names = "pit";
};
@@ -164,7 +165,7 @@
#size-cells = <0>;
compatible = "fsl,vf610-qspi";
reg = <0x40044000 0x1000>;
- interrupts = <0 24 0x04>;
+ interrupts = <0 24 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_QSPI0_EN>,
<&clks VF610_CLK_QSPI0>;
clock-names = "qspi_en", "qspi";
@@ -180,7 +181,7 @@
gpio1: gpio@40049000 {
compatible = "fsl,vf610-gpio";
reg = <0x40049000 0x1000 0x400ff000 0x40>;
- interrupts = <0 107 0x04>;
+ interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
@@ -191,7 +192,7 @@
gpio2: gpio@4004a000 {
compatible = "fsl,vf610-gpio";
reg = <0x4004a000 0x1000 0x400ff040 0x40>;
- interrupts = <0 108 0x04>;
+ interrupts = <0 108 IRQ_TYPE_LEVEL_HIGH>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
@@ -202,7 +203,7 @@
gpio3: gpio@4004b000 {
compatible = "fsl,vf610-gpio";
reg = <0x4004b000 0x1000 0x400ff080 0x40>;
- interrupts = <0 109 0x04>;
+ interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
@@ -213,7 +214,7 @@
gpio4: gpio@4004c000 {
compatible = "fsl,vf610-gpio";
reg = <0x4004c000 0x1000 0x400ff0c0 0x40>;
- interrupts = <0 110 0x04>;
+ interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
@@ -224,7 +225,7 @@
gpio5: gpio@4004d000 {
compatible = "fsl,vf610-gpio";
reg = <0x4004d000 0x1000 0x400ff100 0x40>;
- interrupts = <0 111 0x04>;
+ interrupts = <0 111 IRQ_TYPE_LEVEL_HIGH>;
gpio-controller;
#gpio-cells = <2>;
interrupt-controller;
@@ -242,7 +243,7 @@
#size-cells = <0>;
compatible = "fsl,vf610-i2c";
reg = <0x40066000 0x1000>;
- interrupts =<0 71 0x04>;
+ interrupts =<0 71 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_I2C0>;
clock-names = "ipg";
status = "disabled";
@@ -265,7 +266,7 @@
uart4: serial@400a9000 {
compatible = "fsl,vf610-lpuart";
reg = <0x400a9000 0x1000>;
- interrupts = <0 65 0x04>;
+ interrupts = <0 65 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_UART4>;
clock-names = "ipg";
status = "disabled";
@@ -274,7 +275,7 @@
uart5: serial@400aa000 {
compatible = "fsl,vf610-lpuart";
reg = <0x400aa000 0x1000>;
- interrupts = <0 66 0x04>;
+ interrupts = <0 66 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_UART5>;
clock-names = "ipg";
status = "disabled";
@@ -283,7 +284,7 @@
fec0: ethernet@400d0000 {
compatible = "fsl,mvf600-fec";
reg = <0x400d0000 0x1000>;
- interrupts = <0 78 0x04>;
+ interrupts = <0 78 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_ENET0>,
<&clks VF610_CLK_ENET0>,
<&clks VF610_CLK_ENET>;
@@ -294,7 +295,7 @@
fec1: ethernet@400d1000 {
compatible = "fsl,mvf600-fec";
reg = <0x400d1000 0x1000>;
- interrupts = <0 79 0x04>;
+ interrupts = <0 79 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clks VF610_CLK_ENET1>,
<&clks VF610_CLK_ENET1>,
<&clks VF610_CLK_ENET>;
--
1.7.2.rc3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: vf610: use the interrupt macros
[not found] ` <1387952367-6321-1-git-send-email-b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
@ 2014-01-06 6:04 ` Shawn Guo
[not found] ` <20140106060429.GC27227-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2014-01-06 6:04 UTC (permalink / raw)
To: Huang Shijie, Jingchang Lu
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Wed, Dec 25, 2013 at 02:19:27PM +0800, Huang Shijie wrote:
> This patch uses the IRQ_TYPE_LEVEL_HIGH/IRQ_TYPE_NONE to replace
> the hardcode.
>
> Signed-off-by: Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> arch/arm/boot/dts/vf610.dtsi | 37 +++++++++++++++++++------------------
> 1 files changed, 19 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> index ef8a0ee..cd5bb86 100644
> --- a/arch/arm/boot/dts/vf610.dtsi
> +++ b/arch/arm/boot/dts/vf610.dtsi
> @@ -10,6 +10,7 @@
> #include "skeleton.dtsi"
> #include "vf610-pingrp.h"
> #include <dt-bindings/clock/vf610-clock.h>
> +#include <dt-bindings/interrupt-controller/irq.h>
>
> / {
> aliases {
> @@ -90,7 +91,7 @@
> uart0: serial@40027000 {
> compatible = "fsl,vf610-lpuart";
> reg = <0x40027000 0x1000>;
> - interrupts = <0 61 0x00>;
Why is it so special having a 0x00 IRQ trigger type? Or is it just a
typo? While we are at it, we should probably fix it if it's a typo.
Shawn
> + interrupts = <0 61 IRQ_TYPE_NONE>;
> clocks = <&clks VF610_CLK_UART0>;
> clock-names = "ipg";
> status = "disabled";
> @@ -99,7 +100,7 @@
> uart1: serial@40028000 {
> compatible = "fsl,vf610-lpuart";
> reg = <0x40028000 0x1000>;
> - interrupts = <0 62 0x04>;
> + interrupts = <0 62 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_UART1>;
> clock-names = "ipg";
> status = "disabled";
> @@ -108,7 +109,7 @@
> uart2: serial@40029000 {
> compatible = "fsl,vf610-lpuart";
> reg = <0x40029000 0x1000>;
> - interrupts = <0 63 0x04>;
> + interrupts = <0 63 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_UART2>;
> clock-names = "ipg";
> status = "disabled";
> @@ -117,7 +118,7 @@
> uart3: serial@4002a000 {
> compatible = "fsl,vf610-lpuart";
> reg = <0x4002a000 0x1000>;
> - interrupts = <0 64 0x04>;
> + interrupts = <0 64 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_UART3>;
> clock-names = "ipg";
> status = "disabled";
> @@ -128,7 +129,7 @@
> #size-cells = <0>;
> compatible = "fsl,vf610-dspi";
> reg = <0x4002c000 0x1000>;
> - interrupts = <0 67 0x04>;
> + interrupts = <0 67 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_DSPI0>;
> clock-names = "dspi";
> spi-num-chipselects = <5>;
> @@ -138,7 +139,7 @@
> sai2: sai@40031000 {
> compatible = "fsl,vf610-sai";
> reg = <0x40031000 0x1000>;
> - interrupts = <0 86 0x04>;
> + interrupts = <0 86 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_SAI2>;
> clock-names = "sai";
> status = "disabled";
> @@ -147,7 +148,7 @@
> pit: pit@40037000 {
> compatible = "fsl,vf610-pit";
> reg = <0x40037000 0x1000>;
> - interrupts = <0 39 0x04>;
> + interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_PIT>;
> clock-names = "pit";
> };
> @@ -164,7 +165,7 @@
> #size-cells = <0>;
> compatible = "fsl,vf610-qspi";
> reg = <0x40044000 0x1000>;
> - interrupts = <0 24 0x04>;
> + interrupts = <0 24 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_QSPI0_EN>,
> <&clks VF610_CLK_QSPI0>;
> clock-names = "qspi_en", "qspi";
> @@ -180,7 +181,7 @@
> gpio1: gpio@40049000 {
> compatible = "fsl,vf610-gpio";
> reg = <0x40049000 0x1000 0x400ff000 0x40>;
> - interrupts = <0 107 0x04>;
> + interrupts = <0 107 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> @@ -191,7 +192,7 @@
> gpio2: gpio@4004a000 {
> compatible = "fsl,vf610-gpio";
> reg = <0x4004a000 0x1000 0x400ff040 0x40>;
> - interrupts = <0 108 0x04>;
> + interrupts = <0 108 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> @@ -202,7 +203,7 @@
> gpio3: gpio@4004b000 {
> compatible = "fsl,vf610-gpio";
> reg = <0x4004b000 0x1000 0x400ff080 0x40>;
> - interrupts = <0 109 0x04>;
> + interrupts = <0 109 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> @@ -213,7 +214,7 @@
> gpio4: gpio@4004c000 {
> compatible = "fsl,vf610-gpio";
> reg = <0x4004c000 0x1000 0x400ff0c0 0x40>;
> - interrupts = <0 110 0x04>;
> + interrupts = <0 110 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> @@ -224,7 +225,7 @@
> gpio5: gpio@4004d000 {
> compatible = "fsl,vf610-gpio";
> reg = <0x4004d000 0x1000 0x400ff100 0x40>;
> - interrupts = <0 111 0x04>;
> + interrupts = <0 111 IRQ_TYPE_LEVEL_HIGH>;
> gpio-controller;
> #gpio-cells = <2>;
> interrupt-controller;
> @@ -242,7 +243,7 @@
> #size-cells = <0>;
> compatible = "fsl,vf610-i2c";
> reg = <0x40066000 0x1000>;
> - interrupts =<0 71 0x04>;
> + interrupts =<0 71 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_I2C0>;
> clock-names = "ipg";
> status = "disabled";
> @@ -265,7 +266,7 @@
> uart4: serial@400a9000 {
> compatible = "fsl,vf610-lpuart";
> reg = <0x400a9000 0x1000>;
> - interrupts = <0 65 0x04>;
> + interrupts = <0 65 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_UART4>;
> clock-names = "ipg";
> status = "disabled";
> @@ -274,7 +275,7 @@
> uart5: serial@400aa000 {
> compatible = "fsl,vf610-lpuart";
> reg = <0x400aa000 0x1000>;
> - interrupts = <0 66 0x04>;
> + interrupts = <0 66 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_UART5>;
> clock-names = "ipg";
> status = "disabled";
> @@ -283,7 +284,7 @@
> fec0: ethernet@400d0000 {
> compatible = "fsl,mvf600-fec";
> reg = <0x400d0000 0x1000>;
> - interrupts = <0 78 0x04>;
> + interrupts = <0 78 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_ENET0>,
> <&clks VF610_CLK_ENET0>,
> <&clks VF610_CLK_ENET>;
> @@ -294,7 +295,7 @@
> fec1: ethernet@400d1000 {
> compatible = "fsl,mvf600-fec";
> reg = <0x400d1000 0x1000>;
> - interrupts = <0 79 0x04>;
> + interrupts = <0 79 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&clks VF610_CLK_ENET1>,
> <&clks VF610_CLK_ENET1>,
> <&clks VF610_CLK_ENET>;
> --
> 1.7.2.rc3
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: vf610: use the interrupt macros
[not found] ` <20140106060429.GC27227-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
@ 2014-01-07 7:52 ` Huang Shijie
2014-01-07 9:39 ` Jingchang Lu
0 siblings, 1 reply; 5+ messages in thread
From: Huang Shijie @ 2014-01-07 7:52 UTC (permalink / raw)
To: Shawn Guo
Cc: Jingchang Lu, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Mon, Jan 06, 2014 at 02:04:33PM +0800, Shawn Guo wrote:
> On Wed, Dec 25, 2013 at 02:19:27PM +0800, Huang Shijie wrote:
> > This patch uses the IRQ_TYPE_LEVEL_HIGH/IRQ_TYPE_NONE to replace
> > the hardcode.
> >
> > Signed-off-by: Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> > ---
> > arch/arm/boot/dts/vf610.dtsi | 37 +++++++++++++++++++------------------
> > 1 files changed, 19 insertions(+), 18 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi
> > index ef8a0ee..cd5bb86 100644
> > --- a/arch/arm/boot/dts/vf610.dtsi
> > +++ b/arch/arm/boot/dts/vf610.dtsi
> > @@ -10,6 +10,7 @@
> > #include "skeleton.dtsi"
> > #include "vf610-pingrp.h"
> > #include <dt-bindings/clock/vf610-clock.h>
> > +#include <dt-bindings/interrupt-controller/irq.h>
> >
> > / {
> > aliases {
> > @@ -90,7 +91,7 @@
> > uart0: serial@40027000 {
> > compatible = "fsl,vf610-lpuart";
> > reg = <0x40027000 0x1000>;
> > - interrupts = <0 61 0x00>;
>
> Why is it so special having a 0x00 IRQ trigger type? Or is it just a
> typo? While we are at it, we should probably fix it if it's a typo.
hi Jingchang:
i think it is a typo.
do you any idea about it?
thanks
Huang Shijie
>
> Shawn
>
> > + interrupts = <0 61 IRQ_TYPE_NONE>;
> > clocks = <&clks VF610_CLK_UART0>;
> > clock-names = "ipg";
> > status = "disabled";
> > @@ -99,7 +100,7 @@
> > uart1: serial@40028000 {
> > compatible = "fsl,vf610-lpuart";
> > reg = <0x40028000 0x1000>;
> > - interrupts = <0 62 0x04>;
> > + interrupts = <0 62 IRQ_TYPE_LEVEL_HIGH>;
> > clocks = <&clks VF610_CLK_UART1>;
> > clock-names = "ipg";
> > status = "disabled";
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] ARM: dts: vf610: use the interrupt macros
2014-01-07 7:52 ` Huang Shijie
@ 2014-01-07 9:39 ` Jingchang Lu
[not found] ` <e1421f5854394a4797628684293397da-AZ66ij2kwab4MB1ZSnT4iOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Jingchang Lu @ 2014-01-07 9:39 UTC (permalink / raw)
To: shijie.huang@freescale.com, Shawn Guo
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
> -----Original Message-----
> From: Huang Shijie [mailto:b32955@freescale.com]
> Sent: Tuesday, January 07, 2014 3:52 PM
> To: Shawn Guo
> Cc: Lu Jingchang-B35083; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org
> Subject: Re: [PATCH] ARM: dts: vf610: use the interrupt macros
>
> On Mon, Jan 06, 2014 at 02:04:33PM +0800, Shawn Guo wrote:
> > On Wed, Dec 25, 2013 at 02:19:27PM +0800, Huang Shijie wrote:
> > > This patch uses the IRQ_TYPE_LEVEL_HIGH/IRQ_TYPE_NONE to replace
> > > the hardcode.
> > >
> > > Signed-off-by: Huang Shijie <b32955@freescale.com>
> > > ---
> > > arch/arm/boot/dts/vf610.dtsi | 37 +++++++++++++++++++-------------
> -----
> > > 1 files changed, 19 insertions(+), 18 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/vf610.dtsi
> b/arch/arm/boot/dts/vf610.dtsi
> > > index ef8a0ee..cd5bb86 100644
> > > --- a/arch/arm/boot/dts/vf610.dtsi
> > > +++ b/arch/arm/boot/dts/vf610.dtsi
> > > @@ -10,6 +10,7 @@
> > > #include "skeleton.dtsi"
> > > #include "vf610-pingrp.h"
> > > #include <dt-bindings/clock/vf610-clock.h>
> > > +#include <dt-bindings/interrupt-controller/irq.h>
> > >
> > > / {
> > > aliases {
> > > @@ -90,7 +91,7 @@
> > > uart0: serial@40027000 {
> > > compatible = "fsl,vf610-lpuart";
> > > reg = <0x40027000 0x1000>;
> > > - interrupts = <0 61 0x00>;
> >
> > Why is it so special having a 0x00 IRQ trigger type? Or is it just a
> > typo? While we are at it, we should probably fix it if it's a typo.
> hi Jingchang:
> i think it is a typo.
>
> do you any idea about it?
Yes, it is a typo I made, please help fix it here.
Thanks!
Jingchang
>
> thanks
> Huang Shijie
> >
> > Shawn
> >
> > > + interrupts = <0 61 IRQ_TYPE_NONE>;
> > > clocks = <&clks VF610_CLK_UART0>;
> > > clock-names = "ipg";
> > > status = "disabled";
> > > @@ -99,7 +100,7 @@
> > > uart1: serial@40028000 {
> > > compatible = "fsl,vf610-lpuart";
> > > reg = <0x40028000 0x1000>;
> > > - interrupts = <0 62 0x04>;
> > > + interrupts = <0 62 IRQ_TYPE_LEVEL_HIGH>;
> > > clocks = <&clks VF610_CLK_UART1>;
> > > clock-names = "ipg";
> > > status = "disabled";
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: vf610: use the interrupt macros
[not found] ` <e1421f5854394a4797628684293397da-AZ66ij2kwab4MB1ZSnT4iOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
@ 2014-01-07 13:25 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2014-01-07 13:25 UTC (permalink / raw)
To: Jingchang Lu
Cc: shijie.huang-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
On Tue, Jan 07, 2014 at 09:39:09AM +0000, Jingchang Lu wrote:
> > > > @@ -90,7 +91,7 @@
> > > > uart0: serial@40027000 {
> > > > compatible = "fsl,vf610-lpuart";
> > > > reg = <0x40027000 0x1000>;
> > > > - interrupts = <0 61 0x00>;
> > >
> > > Why is it so special having a 0x00 IRQ trigger type? Or is it just a
> > > typo? While we are at it, we should probably fix it if it's a typo.
> > hi Jingchang:
> > i think it is a typo.
> >
> > do you any idea about it?
> Yes, it is a typo I made, please help fix it here.
Okay. I just fixed it up and applied the patch.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-01-07 13:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-25 6:19 [PATCH] ARM: dts: vf610: use the interrupt macros Huang Shijie
[not found] ` <1387952367-6321-1-git-send-email-b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-01-06 6:04 ` Shawn Guo
[not found] ` <20140106060429.GC27227-rvtDTF3kK1ictlrPMvKcciBecyulp+rMXqFh9Ls21Oc@public.gmane.org>
2014-01-07 7:52 ` Huang Shijie
2014-01-07 9:39 ` Jingchang Lu
[not found] ` <e1421f5854394a4797628684293397da-AZ66ij2kwab4MB1ZSnT4iOO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-01-07 13:25 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).