From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCHv8] video: backlight: gpio-backlight: Add DT support. Date: Tue, 7 Jan 2014 10:42:12 +0000 Message-ID: <20140107104212.GD2930@e106331-lin.cambridge.arm.com> References: <1389088974-31465-1-git-send-email-denis@eukrea.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1389088974-31465-1-git-send-email-denis@eukrea.com> Sender: linux-gpio-owner@vger.kernel.org To: Denis Carikli Cc: Jingoo Han , "linux-gpio@vger.kernel.org" , Alexander Shiyan , Richard Purdie , Laurent Pinchart , "rob.herring@calxeda.com" , Pawel Moll , Stephen Warren , Ian Campbell , "devicetree@vger.kernel.org" , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , Lothar =?utf-8?Q?Wa=C3=9Fmann?= , Jean-Christophe Plagniol-Villard , Thierry Reding , Eric =?utf-8?Q?B=C3=A9nard?= List-Id: devicetree@vger.kernel.org On Tue, Jan 07, 2014 at 10:02:53AM +0000, Denis Carikli wrote: > Cc: Richard Purdie > Cc: Jingoo Han > Cc: Laurent Pinchart > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Stephen Warren > Cc: Ian Campbell > Cc: devicetree@vger.kernel.org > Cc: Sascha Hauer > Cc: linux-arm-kernel@lists.infradead.org > Cc: Lothar Wa=C3=9Fmann > Cc: Jean-Christophe Plagniol-Villard > Cc: Thierry Reding > Cc: Eric B=C3=A9nard > Signed-off-by: Denis Carikli > --- > ChangeLog v7->v8: > - The default-state was renamed to default-brightness-level. > - default-brightness-level is now mandatory, like for backlight-pwm, > That way we avoid having to handle the case where it's not set, > which means that we would need not to set the gpio, but still > report a brightness value for sysfs, when not all gpio controllers = are > able to read the gpio value. > - switched the default-brightness-level to boolean values (0 or 1) in= stead > of using strings ("on", "off", "keep"). > - The documentation was updated accordingly. > - The example in the documentation now uses the dts gpio defines. > - The "backlight: gpio_backlight: Use a default state enum." patch wa= s then > dropped, becuase it is not necessary anymore. >=20 > ChangeLog v6->v7: > - removed a compilation warning with the removal of the useless ret d= eclaration. >=20 > ChangeLog v5->v6: > - The default state handling was reworked: > - it's now called default-state, and looks like the gpio-leds defau= lt-state. > - it now has a "keep" option, like for the gpio-leds. > - that "keep" option is the default when the default-state property= is not set. > - The documentation was updated accordingly. >=20 > ChangeLog v4->v5: > - The default-brightness property now defaults to 0 in the driver. > - def_value int becomes a bool. > - The check for the gpio validity has been reworked. > --- > .../bindings/video/backlight/gpio-backlight.txt | 19 ++++++ > drivers/video/backlight/gpio_backlight.c | 64 ++++++++++= +++++++--- > 2 files changed, 76 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/video/backlight= /gpio-backlight.txt >=20 > diff --git a/Documentation/devicetree/bindings/video/backlight/gpio-b= acklight.txt b/Documentation/devicetree/bindings/video/backlight/gpio-b= acklight.txt > new file mode 100644 > index 0000000..d022add > --- /dev/null > +++ b/Documentation/devicetree/bindings/video/backlight/gpio-backligh= t.txt > @@ -0,0 +1,19 @@ > +gpio-backlight bindings > + > +Required properties: > + - compatible: "gpio-backlight" > + - gpios: describes the gpio that is used for enabling/disabling th= e backlight > + (see GPIO binding[0] for more details). > + - default-brightness-level: the default brightness level. Valid va= lues: > + - 0: off > + - 1: on If this is a boolean, use a boolean/empty property (default-on would be a good candidate, or you could have default-off if most people are goni= g to want the display on at boot). [...] > + ret =3D of_property_read_u32(np, "default-brightness-level", > + &gbl->def_value); This could be: gbl->def_value =3D of_property_read_bool(np, "default-on"); Then you don't have to worry about people doing crazy things like havin= g default-brightness-level =3D <6> when you only support a boolean value. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html